Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932581AbVJ0VMJ (ORCPT ); Thu, 27 Oct 2005 17:12:09 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932636AbVJ0VMJ (ORCPT ); Thu, 27 Oct 2005 17:12:09 -0400 Received: from scrub.xs4all.nl ([194.109.195.176]:35470 "EHLO scrub.xs4all.nl") by vger.kernel.org with ESMTP id S932581AbVJ0VMH (ORCPT ); Thu, 27 Oct 2005 17:12:07 -0400 Date: Thu, 27 Oct 2005 23:11:52 +0200 (CEST) From: Roman Zippel X-X-Sender: roman@scrub.home To: "Fao, Sean" cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] kconfig and lxdialog, kernel 2.6.13.4 In-Reply-To: <4360FB36.1080404@capitalgenomix.com> Message-ID: References: <4360FB36.1080404@capitalgenomix.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 589 Lines: 17 Hi, On Thu, 27 Oct 2005, Fao, Sean wrote: > http://www2.capitalgenomix.com/temp/linux_patch/format_patch Looks fine, but you could also please manually cleanup the parts which got too much indented to the right. Usually one tries to move them into separate functions, but sometimes exceeding the 80 char limit is IMO fine too. bye, Roman - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/