Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751722AbVJ1VAG (ORCPT ); Fri, 28 Oct 2005 17:00:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751723AbVJ1VAG (ORCPT ); Fri, 28 Oct 2005 17:00:06 -0400 Received: from caramon.arm.linux.org.uk ([212.18.232.186]:14600 "EHLO caramon.arm.linux.org.uk") by vger.kernel.org with ESMTP id S1751720AbVJ1VAC (ORCPT ); Fri, 28 Oct 2005 17:00:02 -0400 Date: Fri, 28 Oct 2005 21:59:16 +0100 From: Russell King To: Pavel Machek Cc: Lee Revell , Hugh Dickins , Andi Kleen , vojtech@suse.cz, akpm@osdl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Disable the most annoying printk in the kernel Message-ID: <20051028205916.GL4464@flint.arm.linux.org.uk> Mail-Followup-To: Pavel Machek , Lee Revell , Hugh Dickins , Andi Kleen , vojtech@suse.cz, akpm@osdl.org, linux-kernel@vger.kernel.org References: <200510271026.10913.ak@suse.de> <20051028072003.GB1602@openzaurus.ucw.cz> <1130532239.4363.125.camel@mindpipe> <20051028205132.GB11397@elf.ucw.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20051028205132.GB11397@elf.ucw.cz> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1238 Lines: 34 On Fri, Oct 28, 2005 at 10:51:32PM +0200, Pavel Machek wrote: > Well, keyboard detected and reported an error. Kernel reacted with > printk(). You are removing that printk(). I can understand that, > printk is really annoying, but I really believe _some_ error handling > should be added there if you remove the printk. What do you suggest? Having a TP 380XD which regularly produces this annoying message, it's just logspam. There's no noticable failure. Plus, kernels previous to ones with the new input subsystem just used to ignore the scancode (from v2.[24].xx): int pckbd_translate(unsigned char scancode, unsigned char *keycode, char raw_mode) { ... /* 0xFF is sent by a few keyboards, ignore it. 0x00 is error */ if (scancode == 0x00 || scancode == 0xff) { prev_scancode = 0; return 0; } } -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 Serial core - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/