Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751418AbVJ2GEA (ORCPT ); Sat, 29 Oct 2005 02:04:00 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751419AbVJ2GEA (ORCPT ); Sat, 29 Oct 2005 02:04:00 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:160 "EHLO ZenIV.linux.org.uk") by vger.kernel.org with ESMTP id S1751418AbVJ2GD7 (ORCPT ); Sat, 29 Oct 2005 02:03:59 -0400 Date: Sat, 29 Oct 2005 07:03:44 +0100 From: Al Viro To: Richard Knutsson Cc: Jens Axboe , arnd@arndb.de, davej@redhat.com, kaos@ocs.com.au, linux-kernel@vger.kernel.org Subject: Re: 2.6.14 assorted warnings Message-ID: <20051029060344.GB7992@ftp.linux.org.uk> References: <5455.1130484079@kao2.melbourne.sgi.com> <20051028073049.GA27389@redhat.com> <200510281007.42758.arnd@arndb.de> <20051028082944.GI11441@suse.de> <43630FDA.7010101@student.ltu.se> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <43630FDA.7010101@student.ltu.se> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 864 Lines: 18 On Sat, Oct 29, 2005 at 07:59:54AM +0200, Richard Knutsson wrote: > And on an philosophical plane, can/should we put that responsibility onto > the compiler? Is it not "easier" to make the functions take care > of its own duties (like the *nix-way) and make the bvec_alloc_bs initialize > idx (even if it has to be an error-value)? > > I'm thinking something like this. Seems alright? No. Working around the false positives in compiler warning system is *wrong*. _IF_ it cares to inline the function and generate the warnings based on that, it is responsible for doing it right. It's a gcc bug, plain and simple. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/