From: Andi Kleen <ak@suse.de>
To: Roland Dreier <rolandd@cisco.com>
Subject: Re: [PATCH] x86_64: Work around Re: 2.6.14-git1 (and -git2) build failure on AMD64
Date: Sun, 30 Oct 2005 17:23:31 +0100
User-Agent: KMail/1.8.2
Cc: "Martin J. Bligh" <mbligh@mbligh.org>,
       linux-kernel <linux-kernel@vger.kernel.org>, discuss@x86-64.org
References: <16080000.1130681008@[10.10.2.4]> <200510301649.42064.ak@suse.de> <52br17nfmk.fsf@cisco.com>
In-Reply-To: <52br17nfmk.fsf@cisco.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200510301723.31561.ak@suse.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 741
Lines: 19

On Sunday 30 October 2005 17:17, Roland Dreier wrote:
>     Andi> Linus, can you please apply it?
> 
> No, please don't apply this.  The correct fix is to mark
> toshiba_ohci1394_dmi_table[] as __devinitdata in that file, as in the
> patch I posted here:
> 
>     http://lkml.org/lkml/2005/10/29/12

While not correct I don't see how it should guarantee it will
work around that gcc bug on all possible gcc versions (which show
different behaviour) My patch is more conservative and safer.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/