Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932369AbVJ3WcO (ORCPT ); Sun, 30 Oct 2005 17:32:14 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932371AbVJ3WcN (ORCPT ); Sun, 30 Oct 2005 17:32:13 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:37587 "EHLO ZenIV.linux.org.uk") by vger.kernel.org with ESMTP id S932369AbVJ3WcM (ORCPT ); Sun, 30 Oct 2005 17:32:12 -0500 Date: Sun, 30 Oct 2005 22:32:04 +0000 From: Al Viro To: Alan Cox Cc: Dave Jones , Keith Owens , linux-kernel@vger.kernel.org Subject: Re: 2.6.14 assorted warnings Message-ID: <20051030223204.GO7992@ftp.linux.org.uk> References: <5455.1130484079@kao2.melbourne.sgi.com> <20051028073049.GA27389@redhat.com> <1130710531.32734.5.camel@localhost.localdomain> <20051030222543.GN7992@ftp.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20051030222543.GN7992@ftp.linux.org.uk> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 711 Lines: 25 On Sun, Oct 30, 2005 at 10:25:43PM +0000, Al Viro wrote: > static inline __attribute__((always_inline)) int bar(int n, int *idx) > { > if (n != 1) > return 0; > *idx = 1; > return 1; > } > void baz(int *v, int n) > { > int idx; > int p = bar(n, &idx); > if (__builtin_expect(!p, 0)) > return; > *v |= idx; > } > > and try gcc -Wall on that. Duh. gcc -Wall -Os, of course - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/