DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:date:from:to:cc:subject:message-id:references:mime-version:content-type:content-disposition:in-reply-to:user-agent;
        b=G0XlZyd6+CbB6/iFkTA0oB7YMvyDQyX4BLtrf4ujBWvK0SbCh1cGweP0hlusq/KRUwbrkH2SpTQA4KG6ZPq/m3UMcDF+ppTv2+kZf76yNPMIv1Q+TOtOD961rqDkoV+KT2Egk11kvJVcJxnDb8h7f0IvSWi01sOoWRQTd3MH7LM=
Date: Mon, 31 Oct 2005 16:27:34 +0300
From: Alexey Dobriyan <adobriyan@gmail.com>
To: Ben Dooks <ben-linux@fluff.org>
Cc: hirofumi@mail.parknet.co.jp, linux-kernel@vger.kernel.org
Subject: Re: fs/fat - fix sparse warning
Message-ID: <20051031123525.GA7614@mipter.zuzino.mipt.ru>
References: <20051031113639.GA30667@home.fluff.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20051031113639.GA30667@home.fluff.org>
User-Agent: Mutt/1.5.8i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 953
Lines: 31

On Mon, Oct 31, 2005 at 11:36:39AM +0000, Ben Dooks wrote:
> move fat_cache_init/fat_cache_destroy to a common
> header file in fs/fat so that inode.c and cache.c
> see the same definition, and to stop warnings
> from sparse about undeclared functions

> --- linux-2.6.14-git3/fs/fat/cache.h
> +++ linux-2.6.14-git3-bjd1/fs/fat/cache.h
> @@ -0,0 +1,8 @@
> +/*  linux/fs/fat/cache.h

Every editor can show the name of the current file.

> + *
> + *  Written 1992,1993 by Werner Almesberger
> + *	header, 2005, Ben Dooks
> +*/

Too much for two-line file.

> +
> +extern int __init fat_cache_init(void);
> +extern void fat_cache_destroy(void);

Where did you pick up "extern"? Prototypes in *.c don't have it.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/