Date: Mon, 31 Oct 2005 15:02:33 -0800
From: Matt Mackall <mpm@selenic.com>
To: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org,
       linux-arch@vger.kernel.org
Subject: Re: [PATCH 19/20] inflate: (arch) use proper linking
Message-ID: <20051031230233.GE4367@waste.org>
References: <19.196662837@selenic.com> <20.196662837@selenic.com> <20051031224501.GG20452@flint.arm.linux.org.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20051031224501.GG20452@flint.arm.linux.org.uk>
User-Agent: Mutt/1.5.9i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1041
Lines: 25

On Mon, Oct 31, 2005 at 10:45:01PM +0000, Russell King wrote:
> On Mon, Oct 31, 2005 at 02:54:52PM -0600, Matt Mackall wrote:
> > inflate: remove include of lib/inflate.c and use proper linking
> > 
> > - make free_mem_ptr vars nonstatic
> > - make gunzip nonstatic
> > - add gunzip prototype to new inflate.h
> > - add per-arch Makefile bits
> > - change inflate.c includes to inflate.h includes
> > - change NO_INFLATE_MALLOC to CORE
> > - compile core kernel version of inflate with -DCORE
> 
> We need to build inflate.c with -Dstatic= to disable static data, 
> and text so that we get the correct binary layout for ARM PIC
> decompressors.  This patch breaks that.

So.. we need to add CFLAGS_inflate.o := -Dstatic=? Or is more needed?

-- 
Mathematics is the supreme nostalgia of our time.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/