From: Rob Landley <rob@landley.net>
Organization: Boundaries Unlimited
To: Evgeny Stambulchik <Evgeny.Stambulchik@weizmann.ac.il>
Subject: Re: [PATCH] fix floppy.c to store correct ro/rw status in underlying gendisk
Date: Mon, 31 Oct 2005 17:17:21 -0600
User-Agent: KMail/1.8
Cc: jonathan@jonmasters.org, linux-kernel@vger.kernel.org
References: <4363B081.7050300@jonmasters.org> <35fb2e590510291035n297aa22cv303ae77baeb5c213@mail.gmail.com> <43660693.6040601@weizmann.ac.il>
In-Reply-To: <43660693.6040601@weizmann.ac.il>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200510311717.21676.rob@landley.net>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1350
Lines: 27

On Monday 31 October 2005 05:57, Evgeny Stambulchik wrote:
> Jon Masters wrote:
> > Let me know if this fixes it for you - should bomb out now if you try.
> > The error isn't the cleanest (blame mount), but it does fail.
>
> This works fine, thanks! For what it worth, though, mount -o remount,rw
> says remounting read-only yet still returns success. (Opposite to
> busybox, which now says "Permission denied" - rather misleading, but at
> least it fails).

That sounds like the string translation of EPERM returned by libc's 
strerror().  (At busybox we're frugal bastards; we don't include text 
messages when we can get the C library to provide them for us. :)

But yeah, we're sticklers for correct behavior, and only attempt to remount 
readonly if we get EACCES or EROFS, not _just_ because we attempted a 
read/write mount and it failed.  (And yes, I personally tested this corner 
case.  We haven't started on an automated regression test script for mount 
yet because running it would require root access, but it's on the todo list 
as we upgrade the test suite in our Copious Free Time...)

Rob
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/