Date: Tue, 01 Nov 2005 18:12:29 +0900 (JST)
Message-Id: <20051101.181229.74752004.noboru.obata.ar@hitachi.com>
To: ebiederm@xmission.com
Cc: umka@sevcity.net, fastboot@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [Fastboot] Re: [PATCH] [KDUMP] pending interrupts problem
From: OBATA Noboru <noboru.obata.ar@hitachi.com>
In-Reply-To: <m1u0f2bj18.fsf@ebiederm.dsl.xmission.com>
References: <m1u0f2bj18.fsf@ebiederm.dsl.xmission.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1039
Lines: 38

On Thu, 27 Oct 2005, Eric W. Biederman wrote:
> 
> Alex Lyashkov <umka@sevcity.net> writes:
> 
> > seems to bad patch. you dereference pointer (1) before check to NULL(2).
> 
> Duh.  I forgot to delete the earlier references. 
> That should have been...

Thank you Eric, the patch you resent has fixed the problem,
which originally happened on vanilla 2.6.13.

But, on such an unusual case, I prefer to mark it unlikely() and
output some warning message.

> +	/* Ignore spurious IPIs */
> +	if (!call_data)
> +		return;

	if (unlikely(!call_data)) {
		printk(KERN_WARNING "spurious IPI on CPU#%d, ignored\n",
		       smp_processor_id());
		return;
	}

Please take this if you like it, Eric.  I have also tested this
printk-added code.

Regards,

-- 
OBATA Noboru (noboru.obata.ar@hitachi.com)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/