Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932605AbVKBHIt (ORCPT ); Wed, 2 Nov 2005 02:08:49 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932607AbVKBHIt (ORCPT ); Wed, 2 Nov 2005 02:08:49 -0500 Received: from waste.org ([216.27.176.166]:64198 "EHLO waste.org") by vger.kernel.org with ESMTP id S932605AbVKBHIs (ORCPT ); Wed, 2 Nov 2005 02:08:48 -0500 Date: Tue, 1 Nov 2005 23:03:37 -0800 From: Matt Mackall To: Andrew Morton Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] slob: move kstrdup to lib/string.c Message-ID: <20051102070337.GC4367@waste.org> References: <2.494767362@selenic.com> <20051102170053.1c120a03.akpm@osdl.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20051102170053.1c120a03.akpm@osdl.org> User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 707 Lines: 20 On Wed, Nov 02, 2005 at 05:00:53PM +1100, Andrew Morton wrote: > Matt Mackall wrote: > > > > This move kstrdup to lib/string.c > > The placement in slab.c was deliberate. Putting it in lib/string.c breaks > ppc32. > > ppc32 is reusing lib/string.c to build early userspace or something > like that, and calling kmalloc from there broke stuff. That doesn't sound kosher, have a pointer? -- Mathematics is the supreme nostalgia of our time. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/