In-Reply-To: <20051102054702.GB11266@alpha.home.local>
To: Willy Tarreau <willy@w.ods.org>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
       Yan Zheng <yzcorp@gmail.com>
MIME-Version: 1.0
Subject: Re: [PATCH][MCAST]IPv6: small fix for ip6_mc_msfilter(...)
Message-ID: <OF0C913512.B3EB99A5-ON882570AD.0025FB9D-882570AD.00276427@us.ibm.com>
From: David Stevens <dlstevens@us.ibm.com>
Date: Tue, 1 Nov 2005 23:10:29 -0800
Content-Type: text/plain; charset="US-ASCII"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1400
Lines: 37

Willy Tarreau <willy@w.ods.org> wrote on 11/01/2005 09:47:02 PM:

> Hi,
> 
> On Tue, Nov 01, 2005 at 06:37:43PM +0800, Yan Zheng wrote:
> > You can reproduce this bug by follow codes. This program will cause a
> > change to include report even though the first socket's filter mode is
> > exclude.
> 
> I've not clearly understood the nature of the bug, does it also
> affect 2.4 ? Marcelo will be releasing 2.4.32 in a few days, so
> it would be wise to merge the fix soon.
> 
> Regards,
> Willy
> 

        Yes.
 
        Multicast source filters aren't widely used yet, and that's
really the only feature that's affected if an application actually
exercises this bug, as far as I can tell. An ordinary filter-less
multicast join should still work, and only forwarded multicast
traffic making use of filters and doing empty-source filters with
the MSFILTER ioctl would be at risk of not getting multicast
traffic forwarded to them because the reports generated would not
be based on the correct counts.
        But having the fix in is better than having it broken, even
for that case. :-)

                                                        +-DLS

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/