Message-ID: <43687BE4.3000708@gmail.com>
Date: Wed, 02 Nov 2005 02:42:12 -0600
From: Hareesh Nagarajan <hnagar2@gmail.com>
User-Agent: Thunderbird 1.4 (X11/20050908)
MIME-Version: 1.0
To: Linux Kernel Development <linux-kernel@vger.kernel.org>
CC: akpm@osdl.org
Subject: [PATCH] register_filesystem() must return -EEXIST if the filesystem
 with the same name is already registered
Content-Type: multipart/mixed;
 boundary="------------090901040900030402050304"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1475
Lines: 44

This is a multi-part message in MIME format.
--------------090901040900030402050304
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

If we have a look at the register_filesystem() function defined in 
fs/filesystems.c, we see that if a filesystem with a same name has 
already been registered then the find_filesystem() function will return 
NON-NULL otherwise it will return NULL.

Hence, register_filesystem() should return EEXIST instead of EBUSY. 
Returning EBUSY is misleading (unless of course I'm missing something 
obvious) to the caller of register_filesystem().

Thanks,

Hareesh Nagarajan


--------------090901040900030402050304
Content-Type: text/x-patch;
 name="err-register-filesystem.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="err-register-filesystem.patch"

--- linux-2.6.13.4/fs/filesystems.c	2005-10-10 13:54:29.000000000 -0500
+++ linux-2.6.13.4-edit/fs/filesystems.c	2005-11-02 02:33:30.685600000 -0600
@@ -76,7 +76,7 @@
 	write_lock(&file_systems_lock);
 	p = find_filesystem(fs->name);
 	if (*p)
-		res = -EBUSY;
+		res = -EEXIST;
 	else
 		*p = fs;
 	write_unlock(&file_systems_lock);

--------------090901040900030402050304--
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/