Date: Wed, 2 Nov 2005 17:06:56 +0800
From: Coywolf Qi Hunt <qiyong@fc-cn.com>
To: Hareesh Nagarajan <hnagar2@gmail.com>
Cc: Linux Kernel Development <linux-kernel@vger.kernel.org>, akpm@osdl.org
Subject: Re: [PATCH] register_filesystem() must return -EEXIST if the filesystem with the same name is already registered
Message-ID: <20051102090656.GA12912@localhost.localdomain>
References: <43687BE4.3000708@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <43687BE4.3000708@gmail.com>
User-Agent: Mutt/1.5.11
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1274
Lines: 38

On Wed, Nov 02, 2005 at 02:42:12AM -0600, Hareesh Nagarajan wrote:
> If we have a look at the register_filesystem() function defined in 
> fs/filesystems.c, we see that if a filesystem with a same name has 
> already been registered then the find_filesystem() function will return 
> NON-NULL otherwise it will return NULL.
> 
> Hence, register_filesystem() should return EEXIST instead of EBUSY. 
> Returning EBUSY is misleading (unless of course I'm missing something 
> obvious) to the caller of register_filesystem().

This `slot' is buy, so EBUSY makes sense. Filesytem is not file, hence
EEXIST doesn't apply IMHO.

		Coywolf

> 
> Thanks,
> 
> Hareesh Nagarajan
> 

> --- linux-2.6.13.4/fs/filesystems.c	2005-10-10 13:54:29.000000000 -0500
> +++ linux-2.6.13.4-edit/fs/filesystems.c	2005-11-02 02:33:30.685600000 -0600
> @@ -76,7 +76,7 @@
>  	write_lock(&file_systems_lock);
>  	p = find_filesystem(fs->name);
>  	if (*p)
> -		res = -EBUSY;
> +		res = -EEXIST;
>  	else
>  		*p = fs;
>  	write_unlock(&file_systems_lock);

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/