Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965259AbVKBVcx (ORCPT ); Wed, 2 Nov 2005 16:32:53 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965258AbVKBVcw (ORCPT ); Wed, 2 Nov 2005 16:32:52 -0500 Received: from mx01.stofanet.dk ([212.10.10.11]:59789 "EHLO mx01.stofanet.dk") by vger.kernel.org with ESMTP id S965254AbVKBVcw (ORCPT ); Wed, 2 Nov 2005 16:32:52 -0500 Message-ID: <43692FBB.1000409@stud.feec.vutbr.cz> Date: Wed, 02 Nov 2005 22:29:31 +0100 From: Michal Schmidt User-Agent: Mozilla Thunderbird 1.0 (X11/20041207) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Bill Moss CC: linville@tuxdriver.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2.6.13] airo.c: remove delay in airo_get_scan References: <200511020347.jA23lvi9028538@localhost.localdomain> In-Reply-To: <200511020347.jA23lvi9028538@localhost.localdomain> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1279 Lines: 27 Bill Moss wrote: > Remove 3 second delay in airo_get_scan. Testing shows this delay is unnecessary. Users of NetworkManager > find this delay make NetworkManager slow to connect. > > --- a/drivers/net/wireless/airo.c 2005-11-01 21:21:04.000000000 -0500 > +++ b/drivers/net/wireless/airo.c 2005-11-01 21:22:41.000000000 -0500 > @@ -6918,7 +6918,7 @@ > /* When we are associated again, the scan has surely finished. > * Just in case, let's make sure enough time has elapsed since > * we started the scan. - Javier */ > - if(ai->scan_timestamp && time_before(jiffies,ai->scan_timestamp+3*HZ)) { > + if(ai->scan_timestamp && time_before(jiffies,ai->scan_timestamp)) { > /* Important note : we don't want to block the caller > * until results are ready for various reasons. > * First, managing wait queues is complex and racy > > Signed-off-by: Bill Moss With this change, the time_before() test can't possibly succeed, can it? In that case, why not remove the if and its body completely? Michal - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/