From: Herbert Xu <herbert@gondor.apana.org.au>
To: "Kris Katterjohn" <kjak@users.sourceforge.net>
Subject: Re: [PATCH] Merge __load_pointer() and load_pointer() in net/core/filter.c; kernel 2.6.14
Cc: herbert@gondor.apana.org.au, jschlst@samba.org, torvalds@osdl.org,
       linux-kernel@vger.kernel.org, davem@davemloft.net,
       acme@ghostprotocols.net, netdev@vger.kernel.org
Organization: Core
In-Reply-To: <310a17ad00f84c389e64ae26656ce1a1.kjak@ispwest.com>
User-Agent: tin/1.7.4-20040225 ("Benbecula") (UNIX) (Linux/2.4.27-hx-1-686-smp (i686))
Message-Id: <E1EXUsN-0006r9-00@gondolin.me.apana.org.au>
Date: Thu, 03 Nov 2005 13:30:51 +1100
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1020
Lines: 20

Kris Katterjohn <kjak@ispwest.com> wrote:
> I wasn't actually changing it to add performance, but to make the code look
> cleaner. The new load_pointer() is virtually the same as having the seperate
> functions that are currently there, but the code, I think, is "better looking".
> If you look at the current net/core/filter.c and then my patched version, the
> steps are done in the exact same order and same way, but all in that one
> function.

You've just changed an out-of-line function (__load_pointer) into an
inlined function.  There may be a cost to that.
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/