Date: Thu, 3 Nov 2005 12:45:36 +1100
From: Andrew Morton <akpm@osdl.org>
To: Zach Brown <zach.brown@oracle.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
       hch@infradead.org, mark.fasheh@oracle.com
Subject: Re: [Patch] add AOP_TRUNCATED_PAGE, prepend AOP_ to
 WRITEPAGE_ACTIVATE
Message-Id: <20051103124536.0191bea6.akpm@osdl.org>
In-Reply-To: <43667913.4030401@oracle.com>
References: <43667913.4030401@oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1006
Lines: 19

Zach Brown <zach.brown@oracle.com> wrote:
>
> readpage(), prepare_write(), and commit_write() callers are updated to
>  understand the special return code AOP_TRUNCATED_PAGE in the style of
>  writepage() and WRITEPAGE_ACTIVATE.  AOP_TRUNCATED_PAGE tells the caller that
>  the callee has unlocked the page and that the operation should be tried again
>  with a new page.  OCFS2 uses this to detect and work around a lock inversion in
>  its aop methods.  There should be no change in behaviour for methods that don't
>  return AOP_TRUNCATED_PAGE.
> 
>  WRITEPAGE_ACTIVATE is also prepended with AOP_ for consistency and they are
>  made enums so that kerneldoc can be used to document their semantics.

Looks sane to me.   Can you carry this in the ocfs2 tree?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/