Date: Thu, 3 Nov 2005 18:14:09 -0600
From: Michael Halcrow <lkml@halcrow.us>
To: James Morris <jmorris@namei.org>
Cc: Phillip Hellewell <phillip@hellewell.homeip.net>,
       linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
       mike@halcrow.us, mhalcrow@us.ibm.com, mcthomps@us.ibm.com,
       yoder1@us.ibm.com
Subject: Re: [PATCH 12/12: eCryptfs] Crypto functions
Message-ID: <20051104001409.GB21628@halcrow.us>
Reply-To: Michael Halcrow <lkml@halcrow.us>
References: <20051103033220.GD2772@sshock.rn.byu.edu> <20051103035659.GL3005@sshock.rn.byu.edu> <Pine.LNX.4.63.0511031902570.22256@excalibur.intercode>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Pine.LNX.4.63.0511031902570.22256@excalibur.intercode>
User-Agent: Mutt/1.5.9i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 929
Lines: 28

On Thu, Nov 03, 2005 at 07:08:46PM -0500, James Morris wrote:
> > +	if (likely(1 == crypt_stats->encrypted)) {
> > +		if (!crypt_stats->key_valid) {
> > +			ecryptfs_printk(1, KERN_NOTICE, "Key is "
> > +					"invalid; bailing out\n");
> > +			rc = -EINVAL;
> > +			goto out;
> > +		}
> > +	} else {
> > +		rc = -EINVAL;
> > +		ecryptfs_printk(0, KERN_WARNING,
> > +				"Called with crypt_stats->encrypted == 0\n");
> > +		goto out;
> > +	}
> 
> What's going on here?  Is (crypt_stats->encrypted != 1) a kernel
> bug?

If ecryptfs_write_headers() is ever called on an unencrypted file,
then that is a programming error in eCryptfs. This will need to be
replaced with a BUG_ON().

Mike
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/