Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751591AbVKDQTk (ORCPT ); Fri, 4 Nov 2005 11:19:40 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751602AbVKDQTk (ORCPT ); Fri, 4 Nov 2005 11:19:40 -0500 Received: from 238-193.adsl.pool.ew.hu ([193.226.238.193]:58896 "EHLO dorka.pomaz.szeredi.hu") by vger.kernel.org with ESMTP id S1751589AbVKDQTj (ORCPT ); Fri, 4 Nov 2005 11:19:39 -0500 To: jblunck@suse.de CC: viro@ftp.linux.org.uk, linux-kernel@vger.kernel.org In-reply-to: <20051104160443.GB25491@hasse.suse.de> (jblunck@suse.de) Subject: Re: [RFC,PATCH] libfs dcache_readdir() and dcache_dir_lseek() bugfix References: <20051104113851.GA4770@hasse.suse.de> <20051104115101.GH7992@ftp.linux.org.uk> <20051104122021.GA15061@hasse.suse.de> <20051104131858.GA16622@hasse.suse.de> <20051104151104.GA22322@hasse.suse.de> <20051104154610.GB23962@hasse.suse.de> <20051104160443.GB25491@hasse.suse.de> Message-Id: From: Miklos Szeredi Date: Fri, 04 Nov 2005 17:19:29 +0100 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1499 Lines: 42 > > > > > > > > > > Well, glibc is that stupid and triggers the bug. > > > > > > > > Seems to me, the simple solution is to upgrade your glibc. > > > > > > > > > > This is SLES8. You don't want to update the glibc. > > > > OK, but then it's basically a SLES8 kernel issue, not a mainline > > kernel issue. > > > > Probably very few people are using brand new kernels with glibc from > > the last millennium ;) > > > > Hmm, so I should only send patches for bugs that are often triggered > upstream? Just start using seekdir() and modify the directory contents on an > upstream tmpfs. You'll see that this isn't working well. > > This is a bug and it should get fixed. I hope that it doesn't depend on how > many people using what library :) Ah, but it's a bug in the _system_ and glibc is part of the system too, not just the kernel. Upgrading glibc solves the problem, so why work around it in kernel too? Your patch is not a solution, since readdir will remain nonconforming. It is basically a workaround for a bug in glibc. It makes readdir nonconforming in a different way, but the end result in not necessarily better. If you manage to make dcache_readdir conform to SUS without overly bloating the implementation, that's fine. Miklos - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/