Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750828AbVKDSqf (ORCPT ); Fri, 4 Nov 2005 13:46:35 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750827AbVKDSqf (ORCPT ); Fri, 4 Nov 2005 13:46:35 -0500 Received: from dsl081-059-088.sfo1.dsl.speakeasy.net ([64.81.59.88]:59296 "EHLO piratehaven.org") by vger.kernel.org with ESMTP id S1750821AbVKDSqe (ORCPT ); Fri, 4 Nov 2005 13:46:34 -0500 Date: Fri, 4 Nov 2005 10:46:33 -0800 From: Brian Pomerantz To: netdev@vger.kernel.org Cc: davem@davemloft.net, kuznet@ms2.inr.ac.ru, pekkas@netcore.fi, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@coreworks.de, linux-kernel@vger.kernel.org Subject: [PATCH] [IPV4] Fix secondary IP addresses after promotion Message-ID: <20051104184633.GA16256@skull.piratehaven.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1863 Lines: 58 When 3 or more IP addresses in the same subnet exist on a device and the first one is removed, only the promoted IP address can be reached. Just after promotion of the next IP address, this fix spins through any more IP addresses on the interface and sends a NETDEV_UP notification for that address. This repopulates the FIB with the proper route information. Signed-off-by: Brian Pomerantz --- net/ipv4/devinet.c | 10 ++++++++-- 1 files changed, 8 insertions(+), 2 deletions(-) applies-to: 9bbb209cab841f700162a96e158dfa3ecd361f46 489d4e25469c8329451aca3e91c8e1929e6ecf63 diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c index 4ec4b2c..72d6c93 100644 --- a/net/ipv4/devinet.c +++ b/net/ipv4/devinet.c @@ -235,6 +235,7 @@ static void inet_del_ifa(struct in_devic { struct in_ifaddr *promote = NULL; struct in_ifaddr *ifa1 = *ifap; + struct in_ifaddr *ifa; ASSERT_RTNL(); @@ -243,7 +244,6 @@ static void inet_del_ifa(struct in_devic **/ if (!(ifa1->ifa_flags & IFA_F_SECONDARY)) { - struct in_ifaddr *ifa; struct in_ifaddr **ifap1 = &ifa1->ifa_next; while ((ifa = *ifap1) != NULL) { @@ -294,7 +294,13 @@ static void inet_del_ifa(struct in_devic /* not sure if we should send a delete notify first? */ promote->ifa_flags &= ~IFA_F_SECONDARY; rtmsg_ifa(RTM_NEWADDR, promote); - notifier_call_chain(&inetaddr_chain, NETDEV_UP, promote); + + /* update fib in the rest of this address list */ + ifa = promote; + while (ifa != NULL) { + notifier_call_chain(&inetaddr_chain, NETDEV_UP, ifa); + ifa = ifa->ifa_next; + } } } --- 0.99.9.GIT - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/