Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932184AbVKESeJ (ORCPT ); Sat, 5 Nov 2005 13:34:09 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932192AbVKESeI (ORCPT ); Sat, 5 Nov 2005 13:34:08 -0500 Received: from smtp.osdl.org ([65.172.181.4]:7331 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S932184AbVKESeH (ORCPT ); Sat, 5 Nov 2005 13:34:07 -0500 Date: Sat, 5 Nov 2005 10:33:58 -0800 From: Andrew Morton To: Jon Masters Cc: linux-kernel@vger.kernel.org Subject: Re: PATCH: fix-readonly-policy-use-and-floppy-ro-rw-status Message-Id: <20051105103358.2e61687f.akpm@osdl.org> In-Reply-To: <20051105182728.GB27767@apogee.jonmasters.org> References: <20051105182728.GB27767@apogee.jonmasters.org> X-Mailer: Sylpheed version 1.0.4 (GTK+ 1.2.10; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 905 Lines: 18 Jon Masters wrote: > > [PATCH]: This modifies the gendisk and hd_struct structs to replace "policy" > with "readonly" (as that's the only use for this field). It also introduces a > new function disk_read_only, which behaves like the corresponding device > functions do. I've also replaced direct usage of the old policy fields with > calls to the appropriate function. These are separate things and should be done in separate patches, please. Because, for exmaple, we may decide to revert the floppy change only. Because, as I said off-list, being able to do `remount,rw' of a floppy after having flipped its switch is useful. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/