Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Thu, 4 Oct 2001 02:37:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Thu, 4 Oct 2001 02:37:04 -0400 Received: from chiara.elte.hu ([157.181.150.200]:21513 "HELO chiara.elte.hu") by vger.kernel.org with SMTP id ; Thu, 4 Oct 2001 02:36:55 -0400 Date: Thu, 4 Oct 2001 08:35:02 +0200 (CEST) From: Ingo Molnar Reply-To: To: jamal Cc: Alexey Kuznetsov , , Robert Olsson , , , Linus Torvalds , Alan Cox Subject: Re: [announce] [patch] limiting IRQ load, irq-rewrite-2.4.11-B5 In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 3 Oct 2001, jamal wrote: > > i'm worried by the dev->quota variable a bit. As visible now in the > > 2.4.10-poll.pat and tulip-NAPI-010910.tar.gz code, it keeps calling the > > ->poll() function until dev->quota is gone. I think it should only keep > > calling the function until the rx ring is fully processed - and it should > > re-enable the receiver afterwards, when exiting net_rx_action. > > This would result in an unfairness. Think of one device which receives > packets really fast that it takes most of the CPU capacity just > processing it. no, i asked something else. i'm asking the following thing. dev->quota, as i read the patch now, can cause extra calls to ->poll() even though the RX ring of that particular device is empty and the driver has indicated it's done processing RX packets. (i'm now assuming that the extra-polling-for-a-jiffy line in the current patch is removed - that one is a showstopper to begin with.) Is this claim of mine correct? Ingo - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/