Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932469AbVKGJiW (ORCPT ); Mon, 7 Nov 2005 04:38:22 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932472AbVKGJiW (ORCPT ); Mon, 7 Nov 2005 04:38:22 -0500 Received: from pollux.ds.pg.gda.pl ([153.19.208.7]:3855 "EHLO pollux.ds.pg.gda.pl") by vger.kernel.org with ESMTP id S932469AbVKGJiV (ORCPT ); Mon, 7 Nov 2005 04:38:21 -0500 Date: Mon, 7 Nov 2005 09:38:21 +0000 (GMT) From: "Maciej W. Rozycki" To: Andi Kleen Cc: Zachary Amsden , linux-kernel@vger.kernel.org Subject: Re: 2.6.14: CR4 not needed to be inspected on the 486 anymore? In-Reply-To: Message-ID: References: <436A3C10.9050302@vmware.com> <436AA1FD.3010401@vmware.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 602 Lines: 18 On Sat, 5 Nov 2005, Andi Kleen wrote: > I don't think it's a good idea. Relying on nested faults in oops > is a bit unsafe because it could lead to recursive faults in the worst case. Good point. > Better keep the if Except the condition is wrong. Presence of CR4 could be tested elsewhere though, with the result being the condition here. Maciej - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/