Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964978AbVKGUBL (ORCPT ); Mon, 7 Nov 2005 15:01:11 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965098AbVKGUBL (ORCPT ); Mon, 7 Nov 2005 15:01:11 -0500 Received: from verein.lst.de ([213.95.11.210]:49284 "EHLO mail.lst.de") by vger.kernel.org with ESMTP id S964978AbVKGUBK (ORCPT ); Mon, 7 Nov 2005 15:01:10 -0500 Date: Mon, 7 Nov 2005 20:59:43 +0100 From: Christoph Hellwig To: linas Cc: Greg KH , linux-kernel@vger.kernel.org, bluesmoke-devel@lists.sourceforge.net, Paul Mackerras , linuxppc64-dev@ozlabs.org, linux-pci@atrey.karlin.mff.cuni.cz Subject: Re: [PATCH 1/7]: PCI revised [PATCH 16/42]: PCI: PCI Error reporting callbacks Message-ID: <20051107195943.GA32566@lst.de> References: <20051103235918.GA25616@mail.gnucash.org> <20051104005035.GA26929@mail.gnucash.org> <20051105061114.GA27016@kroah.com> <17262.37107.857718.184055@cargo.ozlabs.ibm.com> <20051107175541.GB19593@austin.ibm.com> <20051107182727.GD18861@kroah.com> <20051107195727.GF19593@austin.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20051107195727.GF19593@austin.ibm.com> User-Agent: Mutt/1.3.28i X-Spam-Score: -4.901 () BAYES_00 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1531 Lines: 39 On Mon, Nov 07, 2005 at 01:57:27PM -0600, linas wrote: > On Mon, Nov 07, 2005 at 10:27:27AM -0800, Greg KH was heard to remark: > > 3) realy strong typing that sparse can detect. > > > PCI Error Recovery: header file patch > > Change enums and subroutine signatures to be strongly typed, per recent > discussion with GregKH. Also, change the acronym to the more unique, > less generic "PERS" "PCI Error Recovery System". > > Greg, Please apply. > > Signed-off-by: Linas Vepstas > > -- > Index: linux-2.6.14-mm1/include/linux/pci.h > =================================================================== > --- linux-2.6.14-mm1.orig/include/linux/pci.h 2005-11-07 13:55:28.528843983 -0600 > +++ linux-2.6.14-mm1/include/linux/pci.h 2005-11-07 13:55:35.745830682 -0600 > @@ -82,11 +82,11 @@ > * the pci device. If some PCI bus between here and the pci device > * has crashed or locked up, this info is reflected here. > */ > -enum pci_channel_state { > +typedef enum { > pci_channel_io_normal = 0, /* I/O channel is in normal state */ > pci_channel_io_frozen = 1, /* I/O to channel is blocked */ > pci_channel_io_perm_failure, /* PCI card is dead */ > -}; > +} pci_channel_state_t; this is not strongly typed, just a completely useless typedef. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/