Date: Mon, 7 Nov 2005 21:20:52 +0100
From: Adrian Bunk <bunk@stusta.de>
To: David Teigland <teigland@redhat.com>
Cc: linux-cluster@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [-mm patch] drivers/dlm/: possible cleanups
Message-ID: <20051107202051.GQ3847@stusta.de>
References: <20051104120640.GB5587@stusta.de> <20051107200431.GC20531@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20051107200431.GC20531@redhat.com>
User-Agent: Mutt/1.5.11
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1165
Lines: 37

On Mon, Nov 07, 2005 at 02:04:31PM -0600, David Teigland wrote:
> On Fri, Nov 04, 2005 at 01:06:40PM +0100, Adrian Bunk wrote:
> > This patch contains the following possible cleanups:
> > - every file should #include the headers containing the prototypes for
> >   it's global functions
> 
> Including unnecessary headers doesn't sound right.
>...

They aren't unnecessary.

If you #include them, gcc can tell when the prototypes in the header and 
the C file are accidentially different.

Without the #include's, this would result in a nasty runtime error.

> Thanks,
> Dave

cu
Adrian

BTW: Please ignore the resending of this patch that overlapped with
     your answer.

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/