Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp3261193yba; Sun, 28 Apr 2019 21:55:43 -0700 (PDT) X-Google-Smtp-Source: APXvYqyiKI2tpXaRhDhVJwfXdgtRsYzHPLgmi/N2tAjzvv7yyb4XH6EQk3rkdjbgoWz/I7TKftQK X-Received: by 2002:a63:cc0c:: with SMTP id x12mr55084161pgf.336.1556513743646; Sun, 28 Apr 2019 21:55:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556513743; cv=none; d=google.com; s=arc-20160816; b=yrQHUqUVHinN19SE7prxsGsdmy0WZB924AbG6GWae8IYNrOkA+UnD95pjVQoUc8xOT EHMxGHH9DEwYIMli9R/VgyF6TXBmsJBQ9+gQ3plV5izAj7og2E7c95QTaFrT7mpoghnU li4Ps2bVqmoLmbyNqXFove5THnw3uVz4o/yCX2X90xrYu0Z0+DtNc3/HelRedfQ5Y4dZ Y8tvHKeXGTUti+RcC0RCPO+0fKqwirjbJ2f+1yM0enAf1wOL5ijHXWzMZX8OFywyF8hk buUF4QqXB+8ynsDfQTGbsq9Yz4Z7Y/gJVq7aYRTQut7HlUeya64WZOaz1bCE1Dpgl7JB HTCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=S+++yQqarWAPcVIwK3Wca+PUa2K/J8tS+1mZnBLISis=; b=xxtBh8PY6ySNVIncwz+zoPzLHZ7e3R4QpBsvNBuq5ejm7MlqpYIZ/oKwsHKTJ5M+aX +Nj77R67jlWvSgO0JsDxUqY+VM32MwDUo+oqYv6zBzo0vDEINItHsBZ3PCmg5MypljSX h83iGo/BEWW4oHwzrdb5mowfTi7ONz9AEwIOhp/uuLIoaNg6AMs6AWAvnGwplWafVW33 JmUikCmYfdHuOfTkt3alvF8LFMfVVMugM0unnyL0DvxAjATGgmHhjMiSCkOEiRej8iJs ZrazJXf0VmvIRzmqWWyPnN71LWywWl9P7NktoU4dPMlIjNHXNCjhZFWMDg+j305W6BiP C9HQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c15si32666987pfr.242.2019.04.28.21.55.28; Sun, 28 Apr 2019 21:55:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727251AbfD2EyK (ORCPT + 99 others); Mon, 29 Apr 2019 00:54:10 -0400 Received: from mga03.intel.com ([134.134.136.65]:28441 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727031AbfD2EyH (ORCPT ); Mon, 29 Apr 2019 00:54:07 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Apr 2019 21:54:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,408,1549958400"; d="scan'208";a="146566285" Received: from iweiny-desk2.sc.intel.com ([10.3.52.157]) by orsmga003.jf.intel.com with ESMTP; 28 Apr 2019 21:54:06 -0700 From: ira.weiny@intel.com To: lsf-pc@lists.linux-foundation.org Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Dan Williams , Jan Kara , =?UTF-8?q?J=C3=A9r=C3=B4me=20Glisse?= , John Hubbard , Michal Hocko , Ira Weiny Subject: [RFC PATCH 03/10] mm/gup: Pass flags down to __gup_device_huge* calls Date: Sun, 28 Apr 2019 21:53:52 -0700 Message-Id: <20190429045359.8923-4-ira.weiny@intel.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190429045359.8923-1-ira.weiny@intel.com> References: <20190429045359.8923-1-ira.weiny@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ira Weiny In order to support taking and/or checking for a LONGTERM lease on a FS DAX inode these calls need to know if FOLL_LONGTERM was specified. This patch passes the flags down but does not use them. It does this in prep for 2 future patches. --- mm/gup.c | 26 +++++++++++++++++--------- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/mm/gup.c b/mm/gup.c index 42680823fbbe..a8ac75bc1452 100644 --- a/mm/gup.c +++ b/mm/gup.c @@ -1853,7 +1853,8 @@ static int gup_pte_range(pmd_t pmd, unsigned long addr, unsigned long end, #if defined(__HAVE_ARCH_PTE_DEVMAP) && defined(CONFIG_TRANSPARENT_HUGEPAGE) static int __gup_device_huge(unsigned long pfn, unsigned long addr, - unsigned long end, struct page **pages, int *nr) + unsigned long end, struct page **pages, int *nr, + unsigned int flags) { int nr_start = *nr; struct dev_pagemap *pgmap = NULL; @@ -1886,30 +1887,33 @@ static int __gup_device_huge(unsigned long pfn, unsigned long addr, } static int __gup_device_huge_pmd(pmd_t orig, pmd_t *pmdp, unsigned long addr, - unsigned long end, struct page **pages, int *nr) + unsigned long end, struct page **pages, int *nr, + unsigned int flags) { unsigned long fault_pfn; int nr_start = *nr; fault_pfn = pmd_pfn(orig) + ((addr & ~PMD_MASK) >> PAGE_SHIFT); - if (!__gup_device_huge(fault_pfn, addr, end, pages, nr)) + if (!__gup_device_huge(fault_pfn, addr, end, pages, nr, flags)) return 0; if (unlikely(pmd_val(orig) != pmd_val(*pmdp))) { undo_dev_pagemap(nr, nr_start, pages); return 0; } + return 1; } static int __gup_device_huge_pud(pud_t orig, pud_t *pudp, unsigned long addr, - unsigned long end, struct page **pages, int *nr) + unsigned long end, struct page **pages, int *nr, + unsigned int flags) { unsigned long fault_pfn; int nr_start = *nr; fault_pfn = pud_pfn(orig) + ((addr & ~PUD_MASK) >> PAGE_SHIFT); - if (!__gup_device_huge(fault_pfn, addr, end, pages, nr)) + if (!__gup_device_huge(fault_pfn, addr, end, pages, nr, flags)) return 0; if (unlikely(pud_val(orig) != pud_val(*pudp))) { @@ -1920,14 +1924,16 @@ static int __gup_device_huge_pud(pud_t orig, pud_t *pudp, unsigned long addr, } #else static int __gup_device_huge_pmd(pmd_t orig, pmd_t *pmdp, unsigned long addr, - unsigned long end, struct page **pages, int *nr) + unsigned long end, struct page **pages, int *nr, + unsigned int flags) { BUILD_BUG(); return 0; } static int __gup_device_huge_pud(pud_t pud, pud_t *pudp, unsigned long addr, - unsigned long end, struct page **pages, int *nr) + unsigned long end, struct page **pages, int *nr, + unsigned int flags) { BUILD_BUG(); return 0; @@ -1946,7 +1952,8 @@ static int gup_huge_pmd(pmd_t orig, pmd_t *pmdp, unsigned long addr, if (pmd_devmap(orig)) { if (unlikely(flags & FOLL_LONGTERM)) return 0; - return __gup_device_huge_pmd(orig, pmdp, addr, end, pages, nr); + return __gup_device_huge_pmd(orig, pmdp, addr, end, pages, nr, + flags); } refs = 0; @@ -1988,7 +1995,8 @@ static int gup_huge_pud(pud_t orig, pud_t *pudp, unsigned long addr, if (pud_devmap(orig)) { if (unlikely(flags & FOLL_LONGTERM)) return 0; - return __gup_device_huge_pud(orig, pudp, addr, end, pages, nr); + return __gup_device_huge_pud(orig, pudp, addr, end, pages, nr, + flags); } refs = 0; -- 2.20.1