Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp3335383yba; Sun, 28 Apr 2019 23:50:39 -0700 (PDT) X-Google-Smtp-Source: APXvYqy5isxBJP+91OOXiTnX86BPDvBKulWiSiBO1bP/X7X1JFtLIwVVbn+oS/BWNFn022DuvBR6 X-Received: by 2002:a63:8f49:: with SMTP id r9mr50642544pgn.306.1556520639221; Sun, 28 Apr 2019 23:50:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556520639; cv=none; d=google.com; s=arc-20160816; b=y/6XPGFgmOasaEbZelai3JHjHUwYOYXbYeTIgLuvqgHuKwOIj59En29M9/DLzGRbf8 NWIkbFIBBEZxoOqqzALVKKlJqRAfJ0LBxPOCcZ1HUdY2S+PbBojkiJFGrM8CJvAaE9Z3 o1bXqTvumFrHyQ44UA8QjrMRQ+X5gQPl8v9UZaEmhMPtosJzoNBqDsIv6855dja4+hhq mQngaks5L/xEf1UASOwGMNM4/S/dh7dqgzQbYXqdAR2TRndQUf92HyZfDAD2ByG7ftQ6 0x8PoWv4bg9fBg25axotGojMLbq9NwVZkQ1SsVwL+NPMWYvr+EvLjXhmMpL4nUfWgWKB 9PnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:from:references:cc:to:subject; bh=5UAQQeV+p8Z/VmO87nMxCh6/t4+a+QlvxS8KbIRP4z8=; b=vP6KcSnLUp07MDHuZurmjxpk5baazlqV3l+nwQTFdPtfGLeADSqS7rGQgDIKd5U031 ObnwSZNF17PI4BsCbzgQbUBGkvh2vaguvXK1mGKRis3ZISGLv6+cP1SVlH8jQrEj6qLx gP8kTRWDVv3/F2zGilhJy7OX2lYyE88SvEc5IYCy3c3pVksnT5SNiHEoFie+AZvHyq6m oUhuJEQPqt4MNngfOPNn4Fjm3uSfFncrmsP9KJ4+btLRib9+hx562pQgLKW++lxrnIRp Ulh+lVIBe6JzneaYA4zckQCfj5eJPp27XSpuTRjox6jNXs0EhDkcuw1fWXzdaSHm6HOU sr3A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a85si32825467pfj.12.2019.04.28.23.50.23; Sun, 28 Apr 2019 23:50:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727308AbfD2Gtc (ORCPT + 99 others); Mon, 29 Apr 2019 02:49:32 -0400 Received: from mout.kundenserver.de ([217.72.192.75]:53559 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726764AbfD2Gtb (ORCPT ); Mon, 29 Apr 2019 02:49:31 -0400 Received: from [192.168.1.110] ([77.9.18.117]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.183]) with ESMTPSA (Nemesis) id 1Mcp3E-1gl7730n7C-00ZzhK; Mon, 29 Apr 2019 08:48:59 +0200 Subject: Re: [PATCH 37/41] drivers: tty: serial: 8250: simplify io resource size computation To: Andy Shevchenko , "Enrico Weigelt, metux IT consult" Cc: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, andrew@aj.id.au, macro@linux-mips.org, vz@mleia.com, slemieux.tyco@gmail.com, khilman@baylibre.com, liviu.dudau@arm.com, sudeep.holla@arm.com, lorenzo.pieralisi@arm.com, davem@davemloft.net, jacmet@sunsite.dk, linux@prisktech.co.nz, matthias.bgg@gmail.com, linux-mips@vger.kernel.org, linux-serial@vger.kernel.org, linux-ia64@vger.kernel.org, linux-amlogic@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org References: <1556369542-13247-1-git-send-email-info@metux.net> <1556369542-13247-38-git-send-email-info@metux.net> <20190428152103.GP9224@smile.fi.intel.com> From: "Enrico Weigelt, metux IT consult" Organization: metux IT consult Message-ID: <431b36fe-3071-fcfd-b04e-b4b293e79a80@metux.net> Date: Mon, 29 Apr 2019 08:48:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20190428152103.GP9224@smile.fi.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:M88UFXLBX4VkHOON6uaOcOnE636KnuLI4S/ApACS+qnAPKvNe1+ 9MFUOX3DMU30BBIWozSwvAEA9pGnmBl6OGeXBQ8Y1viVSeN44w0UCqfu9VYX20rWKj/nkKL vlvP3uU93E8RgsPKi9ujRFjje3G/Y2BUL7L9RvbqLvk4fuIny6ic9WkRhGLxllJ4DYLhyIb wH0HgSJz+Bi+9teW53wMg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:UkSaLiNxTwM=:2TXPwgpE5+RBFRbyUqHOFQ xeHDo/3j0Na0BnkC+0JTCEUa34sTmyQbRB7w4ugZtpJdoNSu1xdU+BMA09hadC91DTT1c0yzO kuk7XpLkyI+N0+19kIGZ5gCjqYsD/gbKZ8Qyy9JocWvi4y1vEXHasSDdt8iTaU9VrQLQy8flK qSDevaqy2gkfA3bR4BtjfkFZnSKHQtpDiqq3mXC+4IcTnAFIySQzIAlEJJiI55bqb+tSkbzKq owQcCerB9D3TCNpnxqqLNVjWK+g79RDFMzNjrcbVvEkGniIRma6jIIKMCyNf42DVoMiMrhh0x aXAPFtRiFh/GxROS/IxKSP4wV6B5wR/h27VqFY21bHhQofeIIGTmI0KiIabQGBsdW35kxOhxg 1i/1jG+pgigRkOKnignHIi2N2wHB6JAqxpWKLNKvEGWP50G0wE8Z6ORBFJtpohgAXfmwiFBxW 3n1pn+bbr+SvajsKMQUl3+ZkelGKovLL03+RClDxUZP2SUJsaCOHtLAKZGFiCfwViK8E8xgfT G9pOuAh4EzKSrpcY52lyA+aZpShZ857A09XO01lj1MT/UIHMroXwGqPKTYB4pmEmeIzsrBOO+ 5T+0kwhObrwWG+hIxyGgBRbGwhYmyae04xr2e8gQMLYXfoA6nSOT3OsoSAIHPclTioTlxFhoE Oa4DTHlLTaZWs27uSZAC9epbFBl9Fx2JmP26IreUA0ypMl3yx9fpLArWCrivScL7WAoEN62AS VaOqKOyMslPbPSY1JUwq9qDAdgT3eIjQcZTeU8BmLykfVe2cq22dosTi4sw= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28.04.19 17:21, Andy Shevchenko wrote: > >> +#define SERIAL_RT2880_IOSIZE 0x100 > > And why this is in the header file and not in corresponding C one? hmm, no particular reason, maybe just an old habit to put definitions into .h files ;-) I can move it to 8250_of.c if you like me to. --mtx -- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering info@metux.net -- +49-151-27565287