Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp3487157yba; Mon, 29 Apr 2019 03:18:42 -0700 (PDT) X-Google-Smtp-Source: APXvYqzayrHkWeDgUHVupe9pphLm21veswkWoU+YyeP1f180TrEUsB0hiolozOxsR2oEuYupNub8 X-Received: by 2002:a17:902:bc81:: with SMTP id bb1mr6565884plb.330.1556533122752; Mon, 29 Apr 2019 03:18:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556533122; cv=none; d=google.com; s=arc-20160816; b=TCSL2xVrXgqqq0m/9ZHrRZR7fBJOoq5beoICCAB3tGQTZ93GfIEH7Iv2QugPwc5WF5 RZvUhY22pfOTNSi+akl+yZtvPuD9KzcgRsYelw+WK4LvHrpKQL/k9jwlVgu0/WfUdJgl LbR48Zv4lL7mg/l0k12EiENGGA+HcbCViznLM4/lmlhJ428iJY4FnF3e0r1wHccL2UUz MUsEBh94X6lc+aa/CKYVEyNBdUJAwTYexUrmMfZlFjqwRJYX3R0CpfO9TdFDhLNO1jNe 2zlAXUNfzOLCyVaRTyWANhsmBWmZ/LtmeKO6NczgN3O9opUPiXiS9hLXXIh2DGcyVDPI C6Ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=agbBFHXfOi1GGUJw9k2j3BKA4XZhYMNmCIwUC1zcAHQ=; b=rbu7R6mfP46cwGGPDLmljbRfyO0ckCJP5xOU0anm+F11mMe+dj/hGUHTlaOztzfhtN JBxk3DuJHfrr1vzNz8c4JM5qvK4FXnYFbuLN9ocMfiUikeW+laQIjriSLvvO7mIKp3pl BrFcuIexr9q3UkvGZaHnh3WdtQYTuOiTYG9senNHH58m07uHbh1fh5xr5GSRXGZ5c2g1 4c2XxLwhUtLzhurD8HeD3NG2JdzfHA5bRtPGhaXz+CWTxeoBTuV209Yhjks5W+rSlpQ6 3ELW7KsaxajlBomE0tBFX5Wap1SdQ2JVqhkkXDSfHKqqO74KRt6efl19/uobViCSwD7x pGUw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k8si4039364pfb.132.2019.04.29.03.18.27; Mon, 29 Apr 2019 03:18:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727710AbfD2KRh (ORCPT + 99 others); Mon, 29 Apr 2019 06:17:37 -0400 Received: from mx2.suse.de ([195.135.220.15]:33222 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727428AbfD2KRh (ORCPT ); Mon, 29 Apr 2019 06:17:37 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id A8327AD22; Mon, 29 Apr 2019 10:17:35 +0000 (UTC) Date: Mon, 29 Apr 2019 12:17:32 +0200 From: Michal Hocko To: Jiri Slaby Cc: Johannes Weiner , Vladimir Davydov , cgroups@vger.kernel.org, mm , Linux kernel mailing list Subject: Re: memcg causes crashes in list_lru_add Message-ID: <20190429101732.GB21837@dhcp22.suse.cz> References: <2cbfb8dc-31f0-7b95-8a93-954edb859cd8@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2cbfb8dc-31f0-7b95-8a93-954edb859cd8@suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 29-04-19 11:25:48, Jiri Slaby wrote: > On 29. 04. 19, 10:16, Jiri Slaby wrote: [...] > > Any idea how to fix this mess? > > memcg_update_all_list_lrus should take care about resizing the array. So > it looks like list_lru_from_memcg_idx returns a stale pointer to > list_lru_from_kmem and then to list_lru_add. Still investigating. I am traveling and on a conference this week. Please open a bug and if this affects upstream kernel then report upstream as well. Cc linux-mm and memcg maintainers. This doesn't ring bells immediately. I do not remember any large changes recently. -- Michal Hocko SUSE Labs