Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp3564377yba; Mon, 29 Apr 2019 04:52:10 -0700 (PDT) X-Google-Smtp-Source: APXvYqzSKaa2G3KpZBOOGAbU6wMAW2A4UrxgtEdHQqav29XEylkvgaXNfbvNHVb3JPQm9vi1/Kll X-Received: by 2002:a63:1301:: with SMTP id i1mr12903677pgl.226.1556538729946; Mon, 29 Apr 2019 04:52:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556538729; cv=none; d=google.com; s=arc-20160816; b=Tn4upiqRhWgStENzjHiZsLgZyf8zUYLQTZig9zlLZC5rqVFF0PrB3C7RNko86ALBTy gVGrLRxmJEEb3/j8yQU/Do5JSLQ+c37BI3V0pZs9ezRV71nRWXB7u14qIikxAKyB7uqR 6fDyBQx6Xr2aO13yusYQ6Ih5CdFpK6mEGccMVY9UkYF4/fqO0DiPbvx98t5C52hPx36h n7PsXxNLo+RK+PJKZUpjsir6WINY8HVryGhtLehP+p0pjyQII6URqy8BWXXDjVebKgM9 SMbd4kO+VWoRn0DPIxWBdF01QMQ36wfsIyceDd/my2fU8NGEHz+DPJny5YvlSi/2y2Rc Im+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=wa/wDfDPow5q1Mg5wLtlDp/FYmdRpLd1fSTrAoW5H3E=; b=diPfxMR3m83B+ZsGnPHkkaAU6dM1P2eXbi34f0L3mORMW0vNSVaGA9MP7E0cfskvar KUbDgKa5vsjwdk2ZOwGN1a2Fsmnw4mvK/ePD4SRaYgvWTT48rCQuPJV575qGXKhTD05Y cxTfkNWSKyvV66RDw0nHFRQrzStti+AW6mNtsKvzhZWz1o8/JBxRfPhSJ8OFYKL1TJmx 2Wn35W+dEsl57/kHS2EWsYix8y+AtYa10Kr83zO4vEoJjFg0I5BmnMcer14+ekedGLc/ JSyo4FTvTUwz8PPkYqXaqvRhtcR39Iw+RJ3+eVJXr8oV3bqJ84geIwj+3zJxc0kqbfOT URYw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u79si33833674pfa.6.2019.04.29.04.51.54; Mon, 29 Apr 2019 04:52:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728024AbfD2Ltf (ORCPT + 99 others); Mon, 29 Apr 2019 07:49:35 -0400 Received: from verein.lst.de ([213.95.11.211]:38021 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727857AbfD2Ltf (ORCPT ); Mon, 29 Apr 2019 07:49:35 -0400 Received: by newverein.lst.de (Postfix, from userid 2407) id D4EC168AFE; Mon, 29 Apr 2019 13:49:18 +0200 (CEST) Date: Mon, 29 Apr 2019 13:49:18 +0200 From: Christoph Hellwig To: Robin Murphy Cc: Christoph Hellwig , Joerg Roedel , Catalin Marinas , Will Deacon , Tom Lendacky , iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 12/21] dma-iommu: factor atomic pool allocations into helpers Message-ID: <20190429114918.GB30460@lst.de> References: <20190327080448.5500-1-hch@lst.de> <20190327080448.5500-13-hch@lst.de> <20190410061157.GA5278@lst.de> <20190417063358.GA24139@lst.de> <83615173-a8b4-e0eb-bac3-1a58d61ea4ef@arm.com> <20190418163512.GA25347@lst.de> <228ee57a-d7b2-48e0-a34e-81d5fba0a090@arm.com> <20190419082348.GA22299@lst.de> <0a6b3f53-79e5-af83-be39-f04c9acd8384@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0a6b3f53-79e5-af83-be39-f04c9acd8384@arm.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 23, 2019 at 11:01:44AM +0100, Robin Murphy wrote: > Wouldn't this suffice? Since we also use alloc_pages() in the coherent > atomic case, the free path should already be able to deal with it. > > Let me take a proper look at v3 and see how it all looks in context. Any comments on v3? I've been deferring lots of other DMA work to not create conflicts, so I'd hate to miss this merge window.