Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp3568591yba; Mon, 29 Apr 2019 04:58:02 -0700 (PDT) X-Google-Smtp-Source: APXvYqyxKaWxd1qX6KChXsLDa75V6I150468yCOon6hMwjMMU5eUpKbOCzs9ut6qj7QT1eyxbLm2 X-Received: by 2002:aa7:92d1:: with SMTP id k17mr63121972pfa.91.1556539082233; Mon, 29 Apr 2019 04:58:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556539082; cv=none; d=google.com; s=arc-20160816; b=mx3kI3rY599U/QvuTjrouvFGaa3Dv+ltwrFtZp5aN7LsbP4MxSX2A21eijMtGvDjBA gchMVfo3GlsRhs1tQykZjJu+5UCiQURDAXxArRHygvmFyzBpqlC5SFUoPCBmrd/1sj+b ylWbMx6Yh3Di7FJ66fb2fp5S0fiKDKMbnOrvi5wv9/rt9ayUt11fVuUMpWvDbl0pPL9Q IBXKB43twCDUtOQRZTLd7nnnMSGrcpz2eIvHiwxCZK2om/DzQDVuD9336b7cf5LdPSRw nfTWsCxIVVZgH93gqwTkB3L8Wm+2Fon95OECHdspiy6v79PK9LPx93NRkfgqQWSragkx Pe9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject; bh=c4DQQlMYpYLPNWy1jkTEOIN3Thpw5NnN0jol7sCodho=; b=zEExNT+NZVunxKWc8QsL16I5U18/j9qj1bviCvrMRVP9eKOYnNp8lmo6S1gSxs1IsC 0p0QFODDsrrwMMSrtoDtpEOI9tPAinCYilDbalwUlKOSV4M2xXcmjWoUGl5ynr9ypoc7 0yTHUfqdoV33fczaSul9IIwHRQ60i+cHHf7ed6IOBSoaJBbwDxvIHL28/Y+dvrQ+I6fX T+Xb8Wo6z2TiV0rB1CgL2vjjfxn6pQMut7RQtNPNSfspeyfG4VYzIyp8xdvlrAN6BaSr NjaEU8kHQ7fia5cYRzTiIp9mx2mTBNM9vw4bc+yBjgAaevAFWBsO3ZV0oJeNnbU3gv0G lNyA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a7si29076049pgw.133.2019.04.29.04.57.46; Mon, 29 Apr 2019 04:58:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728079AbfD2Lzb (ORCPT + 99 others); Mon, 29 Apr 2019 07:55:31 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:54569 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727710AbfD2Lzb (ORCPT ); Mon, 29 Apr 2019 07:55:31 -0400 Received: by mail-wm1-f67.google.com with SMTP id b10so316753wmj.4; Mon, 29 Apr 2019 04:55:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=c4DQQlMYpYLPNWy1jkTEOIN3Thpw5NnN0jol7sCodho=; b=rapsKFJUy0H8g3WAn8xxvkHmdXlljl5Iw1LgDmbugjIsKHZ1SxeLtsdsaP5CCDHJ3G Koj6EMEAw/WYKeJ0asZVz8pYWj7R7cDSjlESINojIfn32/dfIKsIZ6TLKCjOMnzo1E3z J717vealwUMGvDe7rBo4pW9y/icUQdHDgEueqxgrDzg8RJT3MGld5aPGLfE3grBNWciy 8uRqqX2UzK1osx2pCPAntzgM+qzOlfshqzqIXPbi5jzaWm4m/gjmU2AkvzORGxg98rFV /nkO6IRD7XzvkC3xGRLxQHbq2OOCJKMosc7WgyDwC5VmkQdMO7sRlvdrwYFnc7b+FH/6 SU8w== X-Gm-Message-State: APjAAAWlwOQwxzS3H/wAMi9a4jh4V7VkB56ygidiyMA2bq5WPVVNKCF5 oGJVUa3icfcmDIrDFHTs6aA= X-Received: by 2002:a1c:1a85:: with SMTP id a127mr3302088wma.139.1556538929216; Mon, 29 Apr 2019 04:55:29 -0700 (PDT) Received: from ?IPv6:2a0b:e7c0:0:107::49? ([2a0b:e7c0:0:107::49]) by smtp.gmail.com with ESMTPSA id d11sm29364711wrc.32.2019.04.29.04.55.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 29 Apr 2019 04:55:28 -0700 (PDT) Subject: Re: [PATCH] memcg: make it work on sparse non-0-node systems To: Michal Hocko Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Johannes Weiner , Vladimir Davydov , cgroups@vger.kernel.org, Raghavendra K T References: <359d98e6-044a-7686-8522-bdd2489e9456@suse.cz> <20190429105939.11962-1-jslaby@suse.cz> <20190429112916.GI21837@dhcp22.suse.cz> From: Jiri Slaby Openpgp: preference=signencrypt Autocrypt: addr=jslaby@suse.cz; prefer-encrypt=mutual; keydata= mQINBE6S54YBEACzzjLwDUbU5elY4GTg/NdotjA0jyyJtYI86wdKraekbNE0bC4zV+ryvH4j rrcDwGs6tFVrAHvdHeIdI07s1iIx5R/ndcHwt4fvI8CL5PzPmn5J+h0WERR5rFprRh6axhOk rSD5CwQl19fm4AJCS6A9GJtOoiLpWn2/IbogPc71jQVrupZYYx51rAaHZ0D2KYK/uhfc6neJ i0WqPlbtIlIrpvWxckucNu6ZwXjFY0f3qIRg3Vqh5QxPkojGsq9tXVFVLEkSVz6FoqCHrUTx wr+aw6qqQVgvT/McQtsI0S66uIkQjzPUrgAEtWUv76rM4ekqL9stHyvTGw0Fjsualwb0Gwdx ReTZzMgheAyoy/umIOKrSEpWouVoBt5FFSZUyjuDdlPPYyPav+hpI6ggmCTld3u2hyiHji2H cDpcLM2LMhlHBipu80s9anNeZhCANDhbC5E+NZmuwgzHBcan8WC7xsPXPaiZSIm7TKaVoOcL 9tE5aN3jQmIlrT7ZUX52Ff/hSdx/JKDP3YMNtt4B0cH6ejIjtqTd+Ge8sSttsnNM0CQUkXps w98jwz+Lxw/bKMr3NSnnFpUZaxwji3BC9vYyxKMAwNelBCHEgS/OAa3EJoTfuYOK6wT6nadm YqYjwYbZE5V/SwzMbpWu7Jwlvuwyfo5mh7w5iMfnZE+vHFwp/wARAQABtBtKaXJpIFNsYWJ5 IDxqc2xhYnlAc3VzZS5jej6JAjgEEwECACIFAk6S6NgCGwMGCwkIBwMCBhUIAgkKCwQWAgMB Ah4BAheAAAoJEL0lsQQGtHBJgDsP/j9wh0vzWXsOPO3rDpHjeC3BT5DKwjVN/KtP7uZttlkB duReCYMTZGzSrmK27QhCflZ7Tw0Naq4FtmQSH8dkqVFugirhlCOGSnDYiZAAubjTrNLTqf7e 5poQxE8mmniH/Asg4KufD9bpxSIi7gYIzaY3hqvYbVF1vYwaMTujojlixvesf0AFlE4x8WKs wpk43fmo0ZLcwObTnC3Hl1JBsPujCVY8t4E7zmLm7kOB+8EHaHiRZ4fFDWweuTzRDIJtVmrH LWvRDAYg+IH3SoxtdJe28xD9KoJw4jOX1URuzIU6dklQAnsKVqxz/rpp1+UVV6Ky6OBEFuoR 613qxHCFuPbkRdpKmHyE0UzmniJgMif3v0zm/+1A/VIxpyN74cgwxjhxhj/XZWN/LnFuER1W zTHcwaQNjq/I62AiPec5KgxtDeV+VllpKmFOtJ194nm9QM9oDSRBMzrG/2AY/6GgOdZ0+qe+ 4BpXyt8TmqkWHIsVpE7I5zVDgKE/YTyhDuqYUaWMoI19bUlBBUQfdgdgSKRMJX4vE72dl8BZ +/ONKWECTQ0hYntShkmdczcUEsWjtIwZvFOqgGDbev46skyakWyod6vSbOJtEHmEq04NegUD al3W7Y/FKSO8NqcfrsRNFWHZ3bZ2Q5X0tR6fc6gnZkNEtOm5fcWLY+NVz4HLaKrJuQINBE6S 54YBEADPnA1iy/lr3PXC4QNjl2f4DJruzW2Co37YdVMjrgXeXpiDvneEXxTNNlxUyLeDMcIQ K8obCkEHAOIkDZXZG8nr4mKzyloy040V0+XA9paVs6/ice5l+yJ1eSTs9UKvj/pyVmCAY1Co SNN7sfPaefAmIpduGacp9heXF+1Pop2PJSSAcCzwZ3PWdAJ/w1Z1Dg/tMCHGFZ2QCg4iFzg5 Bqk4N34WcG24vigIbRzxTNnxsNlU1H+tiB81fngUp2pszzgXNV7CWCkaNxRzXi7kvH+MFHu2 1m/TuujzxSv0ZHqjV+mpJBQX/VX62da0xCgMidrqn9RCNaJWJxDZOPtNCAWvgWrxkPFFvXRl t52z637jleVFL257EkMI+u6UnawUKopa+Tf+R/c+1Qg0NHYbiTbbw0pU39olBQaoJN7JpZ99 T1GIlT6zD9FeI2tIvarTv0wdNa0308l00bas+d6juXRrGIpYiTuWlJofLMFaaLYCuP+e4d8x rGlzvTxoJ5wHanilSE2hUy2NSEoPj7W+CqJYojo6wTJkFEiVbZFFzKwjAnrjwxh6O9/V3O+Z XB5RrjN8hAf/4bSo8qa2y3i39cuMT8k3nhec4P9M7UWTSmYnIBJsclDQRx5wSh0Mc9Y/psx9 B42WbV4xrtiiydfBtO6tH6c9mT5Ng+d1sN/VTSPyfQARAQABiQIfBBgBAgAJBQJOkueGAhsM AAoJEL0lsQQGtHBJN7UQAIDvgxaW8iGuEZZ36XFtewH56WYvVUefs6+Pep9ox/9ZXcETv0vk DUgPKnQAajG/ViOATWqADYHINAEuNvTKtLWmlipAI5JBgE+5g9UOT4i69OmP/is3a/dHlFZ3 qjNk1EEGyvioeycJhla0RjakKw5PoETbypxsBTXk5EyrSdD/I2Hez9YGW/RcI/WC8Y4Z/7FS ITZhASwaCOzy/vX2yC6iTx4AMFt+a6Z6uH/xGE8pG5NbGtd02r+m7SfuEDoG3Hs1iMGecPyV XxCVvSV6dwRQFc0UOZ1a6ywwCWfGOYqFnJvfSbUiCMV8bfRSWhnNQYLIuSv/nckyi8CzCYIg c21cfBvnwiSfWLZTTj1oWyj5a0PPgGOdgGoIvVjYXul3yXYeYOqbYjiC5t99JpEeIFupxIGV ciMk6t3pDrq7n7Vi/faqT+c4vnjazJi0UMfYnnAzYBa9+NkfW0w5W9Uy7kW/v7SffH/2yFiK 9HKkJqkN9xYEYaxtfl5pelF8idoxMZpTvCZY7jhnl2IemZCBMs6s338wS12Qro5WEAxV6cjD VSdmcD5l9plhKGLmgVNCTe8DPv81oDn9s0cIRLg9wNnDtj8aIiH8lBHwfUkpn32iv0uMV6Ae sLxhDWfOR4N+wu1gzXWgLel4drkCJcuYK5IL1qaZDcuGR8RPo3jbFO7Y Message-ID: <465a4b50-490c-7978-ecb8-d122b655f868@suse.cz> Date: Mon, 29 Apr 2019 13:55:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190429112916.GI21837@dhcp22.suse.cz> Content-Type: text/plain; charset=iso-8859-2 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29. 04. 19, 13:30, Michal Hocko wrote: > On Mon 29-04-19 12:59:39, Jiri Slaby wrote: > [...] >> static inline bool list_lru_memcg_aware(struct list_lru *lru) >> { >> - /* >> - * This needs node 0 to be always present, even >> - * in the systems supporting sparse numa ids. >> - */ >> - return !!lru->node[0].memcg_lrus; >> + return !!lru->node[first_online_node].memcg_lrus; >> } >> >> static inline struct list_lru_one * > > How come this doesn't blow up later - e.g. in memcg_destroy_list_lru > path which does iterate over all existing nodes thus including the > node 0. If the node is not disabled (i.e. is N_POSSIBLE), lru->node is allocated for that node too. It will also have memcg_lrus properly set. If it is disabled, it will never be iterated. Well, I could have used first_node. But I am not sure, if the first POSSIBLE node is also ONLINE during boot? thanks, -- js suse labs