Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp3575623yba; Mon, 29 Apr 2019 05:04:54 -0700 (PDT) X-Google-Smtp-Source: APXvYqy5sHiLD+H2Xyeq4TkLA04nhX12Z0z8bzOivRlRjXo6Qzs64TChk2T9v/b83YJmFCKqot7V X-Received: by 2002:a63:90c7:: with SMTP id a190mr8952200pge.23.1556539494415; Mon, 29 Apr 2019 05:04:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556539494; cv=none; d=google.com; s=arc-20160816; b=NQDyklg6mtQtsWGA10GP8emNDkymAeIlfNGvBE1k6LyuKg8sQK+wDZVs35CPjXwfqN s4PHT5xQVAL8K2s4UIqnB4G3rW0U0umo+gSPLkB2rI4WOSsCgJD7St9lWBUPjauoiT+r qcWCGxSsriX9Eyg8Q7WlS047eVPUR6KTuhaDthIgOShvAdlkLGje2Lo6osW5Ylk/ekDM Kb5HZDmDH2C5eP8AZypw5AU3Iaw7+w//0Fqsn9153n1F/9FnIXUUPs2Ea+DbehohE8Te 6ci4KOZBBjJNQU4q7+DTU1gsnCRAv9C4rs6Ddd4MIRjos+OO3RJK5sMeZvAk6S9YcsvR dcAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=H9/Y41uHuTPaHlSRAI6GEj6TfKXNAJwDia3PTc+DbaY=; b=XfvGPMsP4f7GKFiLsQ+LMdJuA54AGF2VJEt6ZWuPmcsRFvK8kAmJJpCmcd1qNCooAj BkVbHDi4RGBythJtYd+w/sdxDaMkjNV9gPnUdgW+LZu2wGNDjosSsO5Y3TZGL/9Q9KsR RG9VomtHrrzFsUNK7nW9VPjtE44TaHY9cKUjWdQM0cfnwBV7rXiz2ihl95DO+VbF6idO XddZP3WOUGlZ9nhhH1Zw0cGpUjb0dSGWDJ/+DhBNqqrZap03da+YCJWnaNH3ckL/hWym O4yCG7fOjlxJoqqawVGCoWyAg0jxUoSL7nWX9QpWZ+T+kwg4aa1p6jWWSqQLfOSy5zqZ 9PWg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a7si29076049pgw.133.2019.04.29.05.04.36; Mon, 29 Apr 2019 05:04:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728134AbfD2MCi (ORCPT + 99 others); Mon, 29 Apr 2019 08:02:38 -0400 Received: from foss.arm.com ([217.140.101.70]:54880 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727956AbfD2MCf (ORCPT ); Mon, 29 Apr 2019 08:02:35 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 985B6A78; Mon, 29 Apr 2019 05:02:34 -0700 (PDT) Received: from [10.1.196.75] (e110467-lin.cambridge.arm.com [10.1.196.75]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 323F53F5AF; Mon, 29 Apr 2019 05:02:33 -0700 (PDT) Subject: Re: [PATCH 12/21] dma-iommu: factor atomic pool allocations into helpers To: Christoph Hellwig Cc: Joerg Roedel , Catalin Marinas , Will Deacon , Tom Lendacky , iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20190327080448.5500-1-hch@lst.de> <20190327080448.5500-13-hch@lst.de> <20190410061157.GA5278@lst.de> <20190417063358.GA24139@lst.de> <83615173-a8b4-e0eb-bac3-1a58d61ea4ef@arm.com> <20190418163512.GA25347@lst.de> <228ee57a-d7b2-48e0-a34e-81d5fba0a090@arm.com> <20190419082348.GA22299@lst.de> <0a6b3f53-79e5-af83-be39-f04c9acd8384@arm.com> <20190429114918.GB30460@lst.de> From: Robin Murphy Message-ID: <6d99cda0-b7a9-49f2-fbdb-6563fcdd3309@arm.com> Date: Mon, 29 Apr 2019 13:02:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190429114918.GB30460@lst.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/04/2019 12:49, Christoph Hellwig wrote: > On Tue, Apr 23, 2019 at 11:01:44AM +0100, Robin Murphy wrote: >> Wouldn't this suffice? Since we also use alloc_pages() in the coherent >> atomic case, the free path should already be able to deal with it. >> >> Let me take a proper look at v3 and see how it all looks in context. > > Any comments on v3? I've been deferring lots of other DMA work to > not create conflicts, so I'd hate to miss this merge window. Ah, I did skim the commits in the branch, but I'll run through again and reply on the patches while my head's still in email mode... Robin.