Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 29 Apr 2019 16:25:18 +0300
From:   "Kirill A. Shutemov" <kirill@shutemov.name>
To:     Michal Kubecek <mkubecek@suse.cz>
Cc:     Jason Gunthorpe <jgg@mellanox.com>,
        Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: v5.1-rc7 fails to build on s390x (Re: Linux 5.1-rc7)
Message-ID: <20190429132518.75nlcixs3zgerv6c@kshutemo-mobl1>
References: <CAHk-=whvWQbP20g77U4QRXQDS5w+kf=V-P2QjMkgA-OwJJjHtg@mail.gmail.com>
 <20190429052136.GA21672@unicorn.suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190429052136.GA21672@unicorn.suse.cz>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Apr 29, 2019 at 07:21:36AM +0200, Michal Kubecek wrote:
> v5.1-rc7 fails to build on s390x due to
> 
> 		vmf->page = ZERO_PAGE(vmf->vm_start);
> 
> from commit 67f269b37f9b ("RDMA/ucontext: Fix regression with
> disassociate"). This is not a problem on x86_64 where ZERO_PAGE()
> doesn't use its argument but s390 version does.
> 
> I suppose the line should rather read
> 
> 		vmf->page = ZERO_PAGE(vmf->vma->vm_start);
> 
> but I'm just guessing.

I belive it has to be

		vmf->page = ZERO_PAGE(vmf->address);

-- 
 Kirill A. Shutemov