Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp3777313yba; Mon, 29 Apr 2019 08:21:17 -0700 (PDT) X-Google-Smtp-Source: APXvYqyM7rw9Vcp44oxZ4KmU+3zV6EHK6OG9AWlm5c57Ya9aGx1J1l67oEkFexjysghuuo5HIr9H X-Received: by 2002:a63:6cc7:: with SMTP id h190mr58250369pgc.350.1556551277528; Mon, 29 Apr 2019 08:21:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556551277; cv=none; d=google.com; s=arc-20160816; b=JsHcONkae0G+iYq9cNlVobVD3NP8lutFDK6BXphxCIY9W4g2Fp+fVxrYE8R/JFwrBp ZLRLdMOUOgpyaGNM+emmMKugvRFNDFswiCo6ZfYC49d0ZdneEbPn0WIQQu6oU7XI1doa hMnqiRjMeESiBxLYguYMHChdkRVcyKEiP8xpx5RPos0L0LMbDMycJTlm3lvijl9PSxH7 Hdpsp9ZSkG5S23prcU1U27ZS4rPPggjMkXSTT+n4LYN+y/04+VqHaavTWlKz0cEkA94e L3NLxdncFb27CcS8qKNXu19ohXrdsCTnLk7ZEm8RYtQ/3GaIPs8h38fDJPV5GEvHJUiO bUxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:dkim-signature; bh=dPnq76BudBLUCskM0DaeuuctlwoGzT39qQr2q1xJdTg=; b=jK14PZD3TDG9JPsZpxLFv9BVEC9G5mse5l1s6PwkHbLhuZv+nGEg8BOw/ifPf/LeK6 qCWy+DadH8srGX4WTlWV2Nc9fz2JcHIdkmxNaDsq2ylNYEJM9X8H10WGdzBPR7ITSE+u 63RId+MQ48KrVycfvGX0xLonR7TjWNg+1++DRnp2xsHopKhuLDez2RKDnJKfcauY4BwV D/3WdZGVoohNGj7E9W3p8nW4ifUe32sqzmoXkm+UmUVeP2TLQ6Mvwt9VZjZRb3zJ+azO i3tzRye3aASLcIQOg5/vSS6HzE8SSahOVzNIgZ13SyUkffc3XnsLoS5DGVmFBm0vNopz ji/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b="BBvSV/Sr"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u1si34509826pfa.222.2019.04.29.08.21.01; Mon, 29 Apr 2019 08:21:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b="BBvSV/Sr"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728619AbfD2PUC (ORCPT + 99 others); Mon, 29 Apr 2019 11:20:02 -0400 Received: from mail-ed1-f67.google.com ([209.85.208.67]:40332 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728302AbfD2PUC (ORCPT ); Mon, 29 Apr 2019 11:20:02 -0400 Received: by mail-ed1-f67.google.com with SMTP id e56so3190384ede.7; Mon, 29 Apr 2019 08:20:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=dPnq76BudBLUCskM0DaeuuctlwoGzT39qQr2q1xJdTg=; b=BBvSV/SrDNJ31+/UOkSM5bpG5QGX9iuVEAlHSpvrDOGj+4PW80QrSA2NQvvNYxzojp Zd++WkJIJdsJI48+0P5HrqTBvNXDC1r245KbMoADl3uY5vH+mVrnUi6+8qjpF2ydE+tq TwF1hj4480FhhbTHgn4M/QznEs6p0sHaHA9yrWx15VQqD4rerfkEYjhIuk1lUIvL8NJx M8wE73xeYfkcTLVAM5oCB5RVNjauTgvl4PjUAhsoMUZ5oTPhnvZ5wvz6bSMifDGNwT/e KSK9tYNcpfIF8GPBuVeJpf2B9oLlA2ItKshISp7tatkcaGkzhTIiD3dveMl7nJ6B+iIV zmmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=dPnq76BudBLUCskM0DaeuuctlwoGzT39qQr2q1xJdTg=; b=W9s1t/OgV8qqBHvXotuEhe3Mhiwgpg6UMb3tlgDwdL7vTbfT1IIsA8F/0zGK7S5a17 fS6q7av8lzSl6yU2Jxju9wOisr8eM5BTihFR86/+hE+d9V8Qnx27Sn1JRCPMYDaoi8M3 nNMoM5Xx8EMeLOghY2QX1ly1XTuS14trK8M7b+wsoPQ/bBuSjaJEcapV6EdYuv7O6Nyn 5wEw4hhAtE2c+rZYaSWkrvQHt49M1AO+Xr6n9LoIdzFSiu+zHkcHSaNp6zVnZm8o+aD/ 4XRMEWtw8/+cmjbPqsP6m1o776u3kJQfOabTge5T7UwrLkwz4fwPidRXVz8e0QQ9c+vh BFAg== X-Gm-Message-State: APjAAAUfR1FaZgE9tCuK2LQjYH9E/Js7R4wAnV4/ThnKNrmvofTXIN+8 lw3oL/YYSNUvlIzDIMUlvTM= X-Received: by 2002:a17:906:2482:: with SMTP id e2mr12684688ejb.289.1556551199464; Mon, 29 Apr 2019 08:19:59 -0700 (PDT) Received: from dell.be.48ers.dk (d51A5BC31.access.telenet.be. [81.165.188.49]) by smtp.gmail.com with ESMTPSA id p18sm5851269ejm.4.2019.04.29.08.19.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 29 Apr 2019 08:19:58 -0700 (PDT) Received: from peko by dell.be.48ers.dk with local (Exim 4.89) (envelope-from ) id 1hL84T-0000dV-Kj; Mon, 29 Apr 2019 17:19:57 +0200 From: Peter Korsgaard To: "Enrico Weigelt\, metux IT consult" Cc: linux-kernel@vger.kernel.org, lorenzo.pieralisi@arm.com, linux-ia64@vger.kernel.org, linux-serial@vger.kernel.org, andrew@aj.id.au, gregkh@linuxfoundation.org, sudeep.holla@arm.com, liviu.dudau@arm.com, linux-mips@vger.kernel.org, vz@mleia.com, linux@prisktech.co.nz, sparclinux@vger.kernel.org, khilman@baylibre.com, macro@linux-mips.org, slemieux.tyco@gmail.com, matthias.bgg@gmail.com, jacmet@sunsite.dk, linux-amlogic@lists.infradead.org, andriy.shevchenko@linux.intel.com, linuxppc-dev@lists.ozlabs.org, davem@davemloft.net Subject: Re: [PATCH 13/41] drivers: tty: serial: uartlite: fill mapsize and use it References: <1556369542-13247-1-git-send-email-info@metux.net> <1556369542-13247-14-git-send-email-info@metux.net> Date: Mon, 29 Apr 2019 17:19:57 +0200 In-Reply-To: <1556369542-13247-14-git-send-email-info@metux.net> (Enrico Weigelt's message of "Sat, 27 Apr 2019 14:51:54 +0200") Message-ID: <87muk8rg82.fsf@dell.be.48ers.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>>> "Enrico" == Enrico Weigelt, metux IT consult writes: > Fill the struct uart_port->mapsize field and use it, insteaf of s/insteaf/instead/ > hardcoded values in many places. This makes the code layout a bit > more consistent and easily allows using generic helpers for the > io memory handling. > Candidates for such helpers could be eg. the request+ioremap and > iounmap+release combinations. > Signed-off-by: Enrico Weigelt Acked-by: Peter Korsgaard -- Bye, Peter Korsgaard