Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190429060107.10245-1-zajec5@gmail.com>
In-Reply-To: <20190429060107.10245-1-zajec5@gmail.com>
From:   Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Date:   Mon, 29 Apr 2019 12:15:52 -0400
Message-ID: <CAF=yD-+Z=u5Vh=z73BSDrAQZSSXvwOYAxZNLzVMksz5pdfmP=Q@mail.gmail.com>
Subject: Re: [PATCH] net-sysfs: expose IRQ number
To:     =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <zajec5@gmail.com>
Cc:     "David S . Miller" <davem@davemloft.net>,
        Network Development <netdev@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <rafal@milecki.pl>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Apr 29, 2019 at 2:01 AM Rafa=C5=82 Mi=C5=82ecki <zajec5@gmail.com> =
wrote:
>
> From: Rafa=C5=82 Mi=C5=82ecki <rafal@milecki.pl>
>
> Knowing IRQ number makes e.g. reading /proc/interrupts much simpler.
> It's more reliable than guessing device name used by a driver when
> calling request_irq().
>
> Signed-off-by: Rafa=C5=82 Mi=C5=82ecki <rafal@milecki.pl>
> ---
> I found a script parsing /proc/interrupts for a given interface name. It =
wasn't
> working for me as it assumed request_irq() was called with a device name.=
 It's
> not a case for all drivers.
>
> I also found some other people looking for a proper solution for that:
> https://unix.stackexchange.com/questions/275075/programmatically-determin=
e-the-irqs-associated-with-a-network-interface
> https://stackoverflow.com/questions/7516984/retrieving-irq-number-of-a-ni=
c
>
> Let me know if this solution makes sense. I can say it works for me ;)

If parsing /proc/interrupts is problematic, also see the
/sys/kernel/irq interface added in commit ecb3f394c5db ("genirq:
Expose interrupt information through sysfs"). Does that address your
use-case as well? Though it does the inverse mapping from IRQ to name.

Another practical issue is that many network devices register more
than one interrupt. Perhaps one control interrupt, plus one per
receive queue and possibly one per transmit queue. Unfortunately those
cannot be identified in a driver-independent manner. Because an
interface /sys/class/net/$DEV/queues/rx-$i/irq would be useful.