Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp3900830yba; Mon, 29 Apr 2019 10:19:07 -0700 (PDT) X-Google-Smtp-Source: APXvYqzRxWpIRL502jR8RRl/PZajWPy2/T6AOupVwlondr2Nk5dzqcE0OAqVDhNZU7KXXZ3H/Wem X-Received: by 2002:a63:7843:: with SMTP id t64mr59783674pgc.130.1556558347355; Mon, 29 Apr 2019 10:19:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556558347; cv=none; d=google.com; s=arc-20160816; b=KTPuHSozB3A+TtqXA23V1DruZXb+84Bq6ALEGSoioupmvMOAcQy4FFpcc3UEk4KqCd Soh09eVAWl07GJiSMCAFJ6GWLzqA91w+I3U401zVhgVF1KhXarjfSxLGn+XNfo9pRng+ 9t1g17tyNJNESVmAEDi3EBN5eudTwK7VxAMB2XIrOpwyd1/mTafapKGmPH5R6HPC+g87 fLENXwB2+OtgtZIelrxyeVAqMHu4y7jDbrzLXo9hod9cGnbJB5zXKN1HH7hMz2xnFNCA VE5sf/+7Ndz368fgxAL6XdLco0dlTFq7Vn8QrbhvoB4wN2QfLF3T/nx/BK889cYTrCrc 4v9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:references:message-id:date :thread-index:thread-topic:subject:cc:to:from:dkim-signature; bh=rx21fwalFzJuwLlEFvldeNsp0iEkfMYCHIUJGt12hfY=; b=Eej6nt6S5agGk9IeKFIQY7EsLSYVuB5Cp+151zMGBf4CToBJBcjIkBTTotxkVZXAp3 5bydQY48HVBB6gHIwcCV+ztLB0Sao42qJgHodb/nn8IEK5JvpHltG2DoQ5ZzfWgi+k20 dXU0d8nyEjHD2LV13cyGlwjJv7LAFcNpFnztzpSTAQ5GA1VlX6RI4jgb5NSluurv4Imf mVaXPSkE7FBKOTrsFq48vWJ99XrxReY3NbaqBWa5QeJskWR83yb4a7IwQ46BfUVbgFnE hi9F0mPaSsny17k4i/lQxs/vHLc0TT4qVy/o5L91f6IqgXoJGEJH2HvAZMjNNT4Rn/Sf oqXQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@synopsys.com header.s=mail header.b=j9vr3RNo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h20si31285860pgv.352.2019.04.29.10.18.52; Mon, 29 Apr 2019 10:19:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@synopsys.com header.s=mail header.b=j9vr3RNo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728929AbfD2RRy (ORCPT + 99 others); Mon, 29 Apr 2019 13:17:54 -0400 Received: from dc2-smtprelay2.synopsys.com ([198.182.61.142]:45676 "EHLO smtprelay-out1.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728829AbfD2RRy (ORCPT ); Mon, 29 Apr 2019 13:17:54 -0400 Received: from mailhost.synopsys.com (dc8-mailhost2.synopsys.com [10.13.135.210]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by smtprelay-out1.synopsys.com (Postfix) with ESMTPS id 4B5F9C009B; Mon, 29 Apr 2019 17:17:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1556558271; bh=rx21fwalFzJuwLlEFvldeNsp0iEkfMYCHIUJGt12hfY=; h=From:To:CC:Subject:Date:References:From; b=j9vr3RNo7bxDoJ3ou1UiEVj4zkM4uS3kpvE6nJh3tGICOpGKubVQDEWb5sKe9r14m rROXe9L4PqDyh+9gDEbeeszLO950QSAUY+4OylAVQehPboAy8WNmMlSgZ/SHl6VVtL 0fBhz4xVENQhJEDcAaUMS/deHBfNPRRXVSIi0wNQqGXFGB9pThb1kojWzYJmNz0FiL F8rOPdaaxFpOwpwYiIQo5CrPOvzokiwQ8XqlTXWZZQZwedVBig0ZcX+JPLhQMEH9sf /Ag+ZHDFnZj3unGASH6n2jRuOO0VbDudMIEWtz2zrCqQUwfZp3YNTSlx+It3ZFupt0 vPdLqg1cJjikg== Received: from us01wehtc1.internal.synopsys.com (us01wehtc1-vip.internal.synopsys.com [10.12.239.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mailhost.synopsys.com (Postfix) with ESMTPS id EDD0FA007A; Mon, 29 Apr 2019 17:17:50 +0000 (UTC) Received: from us01wembx1.internal.synopsys.com ([169.254.1.223]) by us01wehtc1.internal.synopsys.com ([::1]) with mapi id 14.03.0415.000; Mon, 29 Apr 2019 10:17:51 -0700 From: Vineet Gupta To: Arnaldo Carvalho de Melo CC: Arnaldo Carvalho de Melo , Arnd Bergmann , lkml , "linux-perf-users@vger.kernel.org" , Jiri Olsa , "Namhyung Kim" , arcml Subject: Re: perf tools build broken after v5.1-rc1 Thread-Topic: perf tools build broken after v5.1-rc1 Thread-Index: AQHU9whSYuAYlq2eD0OAivz0M0d5Nw== Date: Mon, 29 Apr 2019 17:17:50 +0000 Message-ID: References: <20190422152027.GB11750@kernel.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.13.184.19] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/22/19 8:31 AM, Arnaldo Carvalho de Melo wrote:=0A= >> A quick fix for ARC will be to create our own version but I presume all = existing=0A= >> arches using generic syscall abi are affected. Thoughts ? In lack of ide= as I'll=0A= >> send out a patch for ARC.=0A= >>=0A= >> P.S. Why do we need the unistd.h duplication in tools directory, given i= t could=0A= >> have used the in-tree unistd headers directly ?=0A= > I have to write down the explanation and have it in a file, but we can't= =0A= > use anything in the kernel from outside tools/ to avoid adding a burden= =0A= > to kernel developers that would then have to make sure that the changes= =0A= > that they make outside tools/ don't break things living there.=0A= =0A= That is a sound guiding principle in general but I don't agree here. unistd= is=0A= backbone of kernel user interface it has to work and can't possibly be brok= en even=0A= when kernel devs add a new syscall is added or condition-alize existing one= . So=0A= adding a copy - and deferring the propagation of in-kernel unistd to usersa= pce=0A= won't necessarily help with anything and it just adds the burden of keeping= them=0A= in sync. Granted we won't necessarily need all the bleeding edge (new sysca= ll=0A= updates) into that header, its still more work.=0A=