Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp3921102yba; Mon, 29 Apr 2019 10:39:57 -0700 (PDT) X-Google-Smtp-Source: APXvYqxahbqQkPyUojhVLyZQPxPtzE9J33gZWKND6shFSMchxuIAcprFvtjaSM4N634AFSIcMU7D X-Received: by 2002:a62:e117:: with SMTP id q23mr3675320pfh.60.1556559597492; Mon, 29 Apr 2019 10:39:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556559597; cv=none; d=google.com; s=arc-20160816; b=KC5QU8tG+8GAXvRg+2PCT9b1ccNxhbM1SsR1nybCQ4bLZfYtdz4UH7iuJJCqdd/SDi Y8QtEr34YHFgD6OjY4sbROIw0l8al/YZIrAiMgTnaNk3vRTn7/P9LSaiCLGP9rZhHMa/ yky9VjHNzN5H6GawNlrTFAmMnJdRoJOiPzqnQl1c1R2yMxz+tX+Gd1PZqY5o8iDO78FE X3ATPWj4oBP0sx6j4wj4+mqTGBmc5yzzpoIXWv+L4fO3qzot+cuQth4WnT1WI7X+10r3 CLZhgBzHe5NwLd6JUWRsxgk/7ZIhqDROQaqohWoHw50/Xjish/8XF3bNYjvdy9dphAVt /WaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-transfer-encoding :content-disposition:mime-version:message-id:subject:cc:to:from:date; bh=WZislfv8gsItGs7PAgcaqZZilKuwZajenFtcD15s4rE=; b=aznF2sDnhmlBxeramq2z5g6N9b5fQUgwcIvWsRvhr6F0u8xjzYWh2MtkERzZZl0eby 3XxKTnZ7Fa6YmvaVtWwSA/FIoAi969Dt3JyResWEwZ8V5PScnIpo/pYzqquGs9rsfw9S 4sAGdhsWYRAh2bV3rRwp6KFU3aMW2n2FfsujgFtvOk6Zl3H0yGk7UtIcfks9M0DuVake E/QCBfuZ0v1pXJi7ohqJE7MR+U4hbhKgw0SK5M7vK3lfu9mrBnwboCu5Xsg7igxhhIu+ u1p5SnuGkZf8a7yXU9AM5ZzCvjzIU12+FPBQrRXv5ZIcmWD0GSIi1vPsa0Mt9eYvxz91 ekGw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v40si33802174plg.409.2019.04.29.10.39.42; Mon, 29 Apr 2019 10:39:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729118AbfD2RiL (ORCPT + 99 others); Mon, 29 Apr 2019 13:38:11 -0400 Received: from gateway22.websitewelcome.com ([192.185.47.125]:44777 "EHLO gateway22.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729034AbfD2RiK (ORCPT ); Mon, 29 Apr 2019 13:38:10 -0400 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway22.websitewelcome.com (Postfix) with ESMTP id CEAD430934 for ; Mon, 29 Apr 2019 12:38:09 -0500 (CDT) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id LAEDhTiO94FKpLAEDhubGe; Mon, 29 Apr 2019 12:38:09 -0500 X-Authority-Reason: nr=8 Received: from [189.250.54.97] (port=58018 helo=embeddedor) by gator4166.hostgator.com with esmtpa (Exim 4.91) (envelope-from ) id 1hLAEC-002Wao-FP; Mon, 29 Apr 2019 12:38:08 -0500 Date: Mon, 29 Apr 2019 12:38:07 -0500 From: "Gustavo A. R. Silva" To: Jakub Kicinski , "David S. Miller" Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH net-next] netdevsim: fix fall-through annotation Message-ID: <20190429173807.GA18088@embeddedor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit User-Agent: Mutt/1.9.4 (2018-02-28) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.250.54.97 X-Source-L: No X-Exim-ID: 1hLAEC-002Wao-FP X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedor) [189.250.54.97]:58018 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 4 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Replace "pass through" with a proper "fall through" annotation in order to fix the following warning: drivers/net/netdevsim/bus.c: In function ‘new_device_store’: drivers/net/netdevsim/bus.c:170:14: warning: this statement may fall through [-Wimplicit-fallthrough=] port_count = 1; ~~~~~~~~~~~^~~ drivers/net/netdevsim/bus.c:172:2: note: here case 2: ^~~~ Warning level 3 was used: -Wimplicit-fallthrough=3 This fix is part of the ongoing efforts to enable -Wimplicit-fallthrough Signed-off-by: Gustavo A. R. Silva --- drivers/net/netdevsim/bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/netdevsim/bus.c b/drivers/net/netdevsim/bus.c index ae482347b67b..fd68eeac574c 100644 --- a/drivers/net/netdevsim/bus.c +++ b/drivers/net/netdevsim/bus.c @@ -168,7 +168,7 @@ new_device_store(struct bus_type *bus, const char *buf, size_t count) switch (err) { case 1: port_count = 1; - /* pass through */ + /* fall through */ case 2: if (id > INT_MAX) { pr_err("Value of \"id\" is too big.\n"); -- 2.21.0