Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 29 Apr 2019 19:57:10 +0200
Message-ID: <s5h5zqwk83t.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     "Wenwen Wang" <wang6495@umn.edu>
Cc:     "moderated list:SOUND" <alsa-devel@alsa-project.org>,
        "Kees Cook" <keescook@chromium.org>,
        "Jaroslav Kysela" <perex@perex.cz>,
        "open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] ALSA: usx2y: fix a double free bug
In-Reply-To: <1556559941-26684-1-git-send-email-wang6495@umn.edu>
References: <1556559941-26684-1-git-send-email-wang6495@umn.edu>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 29 Apr 2019 19:45:40 +0200,
Wenwen Wang wrote:
> 
> In usX2Y_In04_init(), a new urb is firstly created through usb_alloc_urb()
> and saved to 'usX2Y->In04urb'. Then, a buffer is allocated through
> kmalloc() and saved to 'usX2Y->In04Buf'. If the allocation of the buffer
> fails, the error code ENOMEM is returned after usb_free_urb(), which frees
> the created urb. However, the urb is actually freed at card->private_free
> callback, i.e., snd_usX2Y_card_private_free(). So the free operation here
> leads to a double free bug.
> 
> To fix the above issue, simply remove usb_free_urb().
> 
> Signed-off-by: Wenwen Wang <wang6495@umn.edu>

Applied now.  Thanks.


Takashi