Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp4002130yba; Mon, 29 Apr 2019 12:03:26 -0700 (PDT) X-Google-Smtp-Source: APXvYqwOe8jXw3EFvxEh6yDzeuZz2G9ja72/EUmC62r2pqL7WrBFo7IGEi+HXi0AbkRBNSd8cqY8 X-Received: by 2002:aa7:978f:: with SMTP id o15mr8917006pfp.173.1556564605969; Mon, 29 Apr 2019 12:03:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556564605; cv=none; d=google.com; s=arc-20160816; b=X1VYtw+IDbryI7BLBpyVVL81Q9tFvpzMufD3cos8YIpEvqbXsXdhPdE/Lw+H095IoX me6nEqs/bl40xArMcKLtmckrotXcbL2pMee/rm0Dcs6votCoemeaKKppXr/w2YycXZo/ tzCpJhCIUfBizNEUbcOhqKHy0Pv9hI/35/SDmV1EFdXh7TbPElHtPV3/po22aVAyNu3y OCmTfYE6U+Ggu/gbi5sluXaGz+ml5VPnbkOgJohFaZXqqRpw0vGU/zY6r5F+58ve5Ugx habjcRjeaehOCzaf0suCOu4e9dhsWrHxAm1t+nDzzVx04NtgQMByA13MyWyugJ7UVHbn qgFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=KM7sBn2ntPUYOEazp7/3IkElEYpyQmbNoNzjCXQsvm4=; b=LpDW6EVsOTObgVPJKaqvj3PS8V9q3g2h2dqP1iWhBoBEWdi6P2lsXycXlVeVBzZi71 9dKQG4qgYhPUuf9Eq7NWoWYmKslnOubN2g3//QPmfilWxs0/Y8zEMAJ3WybczYxBIWjK 5mxZPngBQKAEuHL+r6zSRG4ZO5aHCHFnXgXptTOG7rrhMUFLxPF5+n7GwwWH5RhjY/SB bdr6A7UX6kDyN/l3sXfOJWF72Tlo7p/eHYANoCEigHA72y4usGb6ujn+nOfPWXyMJe88 IACQT1G6Qad0GupEibv8WAaUppsoVeQTUHnb7sowpJ0lqvHeLu8AO1nkmjPf1kzjJ3EI AteA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k4si13495158pgs.232.2019.04.29.12.03.05; Mon, 29 Apr 2019 12:03:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729083AbfD2TBi (ORCPT + 99 others); Mon, 29 Apr 2019 15:01:38 -0400 Received: from verein.lst.de ([213.95.11.211]:40574 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728946AbfD2TBh (ORCPT ); Mon, 29 Apr 2019 15:01:37 -0400 Received: by newverein.lst.de (Postfix, from userid 2407) id 978DE68AFE; Mon, 29 Apr 2019 21:01:20 +0200 (CEST) Date: Mon, 29 Apr 2019 21:01:20 +0200 From: Christoph Hellwig To: Robin Murphy Cc: Christoph Hellwig , Joerg Roedel , Catalin Marinas , Will Deacon , Tom Lendacky , iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 02/26] arm64/iommu: improve mmap bounds checking Message-ID: <20190429190120.GA5637@lst.de> References: <20190422175942.18788-1-hch@lst.de> <20190422175942.18788-3-hch@lst.de> <306b7a19-4eb5-d1d8-5250-40f3ba9bca16@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <306b7a19-4eb5-d1d8-5250-40f3ba9bca16@arm.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 29, 2019 at 01:35:46PM +0100, Robin Murphy wrote: > On 22/04/2019 18:59, Christoph Hellwig wrote: >> The nr_pages checks should be done for all mmap requests, not just those >> using remap_pfn_range. > > I think it probably makes sense now to just squash this with #22 one way or > the other, but if you really really still want to keep it as a separate > patch with a misleading commit message then I'm willing to keep my > complaints to myself :) Well, I split this out in response to your earlier comments, so if you prefer it squasheѕ back in I can do that..