Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: moNGso2BXe3GzkkuzU5F5AfvPyzy1Ul7eRZWgOPQWety8v3m/4zGlStQSS2hY0og1c6W5TKGVc
 9icRKPxxqqYSSnQ7mh5VJj8SjEQQ2SUx7s6yDL+OZwv9OBlRfyNNn27ojTWzjzhst5TJQXCigk
 KkOIWL2AmDYuHvbjo1e2IF+Dx9a+XNgg1gfsd0/dmdbzc3pOsOPcvFnADjZ4gbzXiRzVM9028O
 8+tLuMSRHI1aO8pdDJe9m6yljn2wju2PRL7aPCU7xTbg3B800nkLSzp6g0wNINYmRfkmOVDZuN
 zX3bdcteJ0vaMmq+F6n7rKCV
IronPort-SDR: 3DPb2PcWrl1lZn4c6cs7QX/GL1L2Mxk3qhbjtbqE5SnoEhVGLGsgYQp0Eb/dU+1MLJeRk4bK3V
 ++ljP17iEXBQXhrYVqDmr4IQi85GLF5yUyR9vBG9J79W2VBZ47HDcTonMJv8Q8Vp3og0a2fWCm
 gHe62TeuS05QO2Sgsw0CubbfQQpT6tj+1qYdgd6WTbZTEdI8miJdVoToYEPkSs41VfHPxeuTuj
 X4dDWhnvFJ9TTmKowheCJ/nsz7dfXizAcBxDYwXIRBfwu6nC4/zlIE8JC/pWnMdBoW4sCTmryI
 Mmk=
Subject: Re: [PATCH v2 1/3] x86: Move DEBUG_TLBFLUSH option.
To:     Ingo Molnar <mingo@kernel.org>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Albert Ou <aou@eecs.berkeley.edu>,
        Andrew Morton <akpm@linux-foundation.org>,
        Anup Patel <anup@brainfault.org>,
        Borislav Petkov <bp@alien8.de>,
        Changbin Du <changbin.du@intel.com>,
        Gary Guo <gary@garyguo.net>, "H. Peter Anvin" <hpa@zytor.com>,
        Ingo Molnar <mingo@redhat.com>,
        Kees Cook <keescook@chromium.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-riscv@lists.infradead.org" <linux-riscv@lists.infradead.org>,
        Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
        Palmer Dabbelt <palmer@sifive.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Vlastimil Babka <vbabka@suse.cz>,
        "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@kernel.org>,
        Christoph Hellwig <hch@infradead.org>
References: <20190429195759.18330-1-atish.patra@wdc.com>
 <20190429195759.18330-2-atish.patra@wdc.com>
 <20190429200554.GA102486@gmail.com>
From:   Atish Patra <atish.patra@wdc.com>
Message-ID: <e80533d1-6d7c-c503-73d7-1a344a49aa37@wdc.com>
Date:   Mon, 29 Apr 2019 14:29:43 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0)
 Gecko/20100101 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <20190429200554.GA102486@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 4/29/19 1:06 PM, Ingo Molnar wrote:
> 
> * Atish Patra <atish.patra@wdc.com> wrote:
> 
>> CONFIG_DEBUG_TLBFLUSH was added in 'commit 3df3212f9722 ("x86/tlb: add
>> tlb_flushall_shift knob into debugfs")' to support tlb_flushall_shift
>> knob. The knob was removed in 'commit e9f4e0a9fe27 ("x86/mm: Rip out
>> complicated, out-of-date, buggy TLB flushing")'.  However, the debug
>> option was never removed from Kconfig. It was reused in commit
>> '9824cf9753ec ("mm: vmstats: tlb flush counters")' but the commit text
>> was never updated accordingly.
> 
> Please, when you mention several commits, put them into new lines to make
> it readable, i.e.:
> 
>    3df3212f9722 ("x86/tlb: add tlb_flushall_shift knob into debugfs")
> 
> etc.
> 
Done.

>> Update the Kconfig option description as per its current usage.
>>
>> Take this opprtunity to make this kconfig option a common option as it
>> touches the common vmstat code. Introduce another arch specific config
>> HAVE_ARCH_DEBUG_TLBFLUSH that can be selected to enable this config.
> 
> "opprtunity"?
> 
>> +config HAVE_ARCH_DEBUG_TLBFLUSH
>> +	bool
>> +	depends on DEBUG_KERNEL
>> +
>> +config DEBUG_TLBFLUSH
>> +	bool "Save tlb flush statstics to vmstat"
>> +	depends on HAVE_ARCH_DEBUG_TLBFLUSH
>> +	help
>> +
>> +	Add tlbflush statstics to vmstat. It is really helpful understand tlbflush
>> +	performance and behavior. It should be enabled only for debugging purpose
>> +	by individual architectures explicitly by selecting HAVE_ARCH_DEBUG_TLBFLUSH.
> 
> "statstics"??
> 
> Please put a spell checker into your workflow or read what you are
> writing ...
> 

Apologies for the typos. Fixed them.

Regards,
Atish
> Thanks,
> 
> 	Ingo
>