Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To:     Minwoo Im <minwoo.im.dev@gmail.com>
CC:     Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
        "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] nvmet: fix ptr_ret.cocci warnings
Thread-Topic: [PATCH] nvmet: fix ptr_ret.cocci warnings
Thread-Index: AQHU/rUi/X3mcWJFukeNj8Wd9t7TxQ==
Date:   Mon, 29 Apr 2019 22:14:15 +0000
Message-ID: <SN6PR04MB45271D793C898E527914578086390@SN6PR04MB4527.namprd04.prod.outlook.com>
References: <201904300131.gB7Qr2Ik%lkp@intel.com>
 <20190429175734.GA20932@lkp-kbuild08>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 641456d2-10ed-436e-939f-08d6ccf00441
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Apr 2019 22:14:15.4177
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR04MB4319
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Minwoo,=0A=
=0A=
Can you please resend this patch with the suggested change ?=0A=
=0A=
On 04/29/2019 10:58 AM, kbuild test robot wrote:=0A=
> From: kbuild test robot <lkp@intel.com>=0A=
>=0A=
> drivers/nvme/target/discovery.c:375:1-3: WARNING: PTR_ERR_OR_ZERO can be =
used=0A=
>=0A=
>=0A=
>   Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR=0A=
>=0A=
> Generated by: scripts/coccinelle/api/ptr_ret.cocci=0A=
>=0A=
> Fixes: 6b7e631b927c ("nvmet: return a specified error it subsys_alloc fai=
ls")=0A=
> CC: Minwoo Im <minwoo.im.dev@gmail.com>=0A=
> Signed-off-by: kbuild test robot <lkp@intel.com>=0A=
> ---=0A=
>=0A=
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.g=
it master=0A=
> head:   3d17a1de96a233cf89bfbb5a77ebb1a05c420681=0A=
> commit: 6b7e631b927ca1266b2695307ab71ed7764af75e [9188/10649] nvmet: retu=
rn a specified error it subsys_alloc fails=0A=
>=0A=
>   discovery.c |    4 +---=0A=
>   1 file changed, 1 insertion(+), 3 deletions(-)=0A=
>=0A=
> --- a/drivers/nvme/target/discovery.c=0A=
> +++ b/drivers/nvme/target/discovery.c=0A=
> @@ -372,9 +372,7 @@ int __init nvmet_init_discovery(void)=0A=
>   {=0A=
>   	nvmet_disc_subsys =3D=0A=
>   		nvmet_subsys_alloc(NVME_DISC_SUBSYS_NAME, NVME_NQN_DISC);=0A=
> -	if (IS_ERR(nvmet_disc_subsys))=0A=
> -		return PTR_ERR(nvmet_disc_subsys);=0A=
> -	return 0;=0A=
> +	return PTR_ERR_OR_ZERO(nvmet_disc_subsys);=0A=
>   }=0A=
>=0A=
>   void nvmet_exit_discovery(void)=0A=
>=0A=
=0A=