Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp4299204yba; Mon, 29 Apr 2019 17:40:06 -0700 (PDT) X-Google-Smtp-Source: APXvYqx6uAKDdmCrcLNzscg3EbK//3h6+HKaMUwt2SQFgRwQY3Is6U1L20JXhIGzv0hvf7C2ocNM X-Received: by 2002:a17:902:6b0b:: with SMTP id o11mr29581265plk.266.1556584806307; Mon, 29 Apr 2019 17:40:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556584806; cv=none; d=google.com; s=arc-20160816; b=Vd4T0JOPglFJjdbrNrfu5hBLzo2E02MLzez5cm28JUZckC07WYCBQoZ+jmudsOESsk B0pK1YPkraIauS8O1dlSsjUbWNRbclPqJ6JbgvdmeiDOrzlc6f6TVuzP0DrHIrhvaJVY FNBkil+aPdnZjDSFy5MhuhpDscb0eUWJlH6h/nwylstWWWTG4L+MkB7Z7fLpzxufEd3v S53h5LjCn17hUlZla2r78YmZxqcOSi1xcTTqgG4Kd4xxyQTzzOmerSQZXg24u/yGIDbo t6kTnTW7fF4JFL5ZbMhFiZSQlfnlcFzdMnlGHatnQNFlrQS8Df+D4tmxJ60z0141lsx4 jnYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:to:from:cc:in-reply-to:subject:date:dkim-signature; bh=GbaCh6NhvaphvajOZaGIcMKIlJS94Qzf/VlSIykaLPU=; b=f8n3V3mh5795stbxKzCLHDFr91OkP4/96pYYjHL8fbFuj1pbZ96hFd9lLg50jboatU B5LQLOoEObdIpC12lWINoepRZCvGBGWUdLF5JIhiREfFfDZUzaMEAfAfKFzY5Z9SwjvT EDNLHosQkDEZh/B5fRme6lWazwhbyWcwBO+7Gl2Bz4gA2kG475Y7GgVA87UsaHFsqySa uJXsnwlvvt5FIt/7cz98Xmek3aWLpi3hmEYMieEb68hM8OzcQPuVZoFsYa962ww1T5Yv G8xwY29hvnqLD63HfzGF+oTxv8Xfe/VGeoHBHerJ4H4oUNYoqgncNZaOPemarAJcjL5y XWSQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sifive.com header.s=google header.b=hMN6CoeY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h73si37694206pfj.220.2019.04.29.17.39.49; Mon, 29 Apr 2019 17:40:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@sifive.com header.s=google header.b=hMN6CoeY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729701AbfD3Agy (ORCPT + 99 others); Mon, 29 Apr 2019 20:36:54 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:45490 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729238AbfD3Agy (ORCPT ); Mon, 29 Apr 2019 20:36:54 -0400 Received: by mail-pf1-f193.google.com with SMTP id e24so6158741pfi.12 for ; Mon, 29 Apr 2019 17:36:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=date:subject:in-reply-to:cc:from:to:message-id:mime-version :content-transfer-encoding; bh=GbaCh6NhvaphvajOZaGIcMKIlJS94Qzf/VlSIykaLPU=; b=hMN6CoeYmgoCw44mrL758sSSkEbr6V6KKiWzQhocmqfTxNVGtMqcnR/RW5Ab++FnNa 4liF+DSBZ95xJ8oIbBfRb1mHSNy+XsdXWvsLnmD/NMVU+tKIWb31EvHvtFucIoGnOwJ0 4Cc+2gt9S95VOhgUgt4FG7VkKwY2DS6D+vwpVl7+oZfaDEjLBbWkwqncS0PtIQPj5r+w iGr0rd6ssbA7mbpfLhR4E+hTs15pcCklhXkjSQOMwf84TrhK9EE+WTwbLp/ohY8zXhZq YyFdKFByYNdmsx2ONAqhaoo6/bhfOvXj646nxuk4rgiEnmGJKeWG1AnQx5udDWyv58IR yOEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:subject:in-reply-to:cc:from:to:message-id :mime-version:content-transfer-encoding; bh=GbaCh6NhvaphvajOZaGIcMKIlJS94Qzf/VlSIykaLPU=; b=JAzI3hAfuDYQpvtZUI5tVw7mawn9vN8OKhTM6mLJ0MMksE24s4m4xNwbbdTTttbl0u Zey4tadu80Su4zlw06R8YFSgaInHBH8EyXinOVEIaAAhBfqw8KdDWsrI7UyiJeNFRQOh fasa61ZT4Pspr1j6/gUlnXBZIvfU5SgDGVYn/ujRyXLjDKHMGkopY5ixcsDgUziwBFZ4 Cj6i49zH7eN66hY19gvEK5Nhf/P05IoljC/quCxMochd5rRNMK1Y8i0mbjpv49Sq+g52 FcCHbd7ea7PNF4djoEUsCWm8miCLCQXM4ai8XBFgp3AvAWra5ypVFqZuFMVbJnPAXhLv HEyA== X-Gm-Message-State: APjAAAVKl6Mlly7A8UTJl3JLhgFYpLf5NpwkcEEc3DPIol0RDBcRvTE0 xbreKDanmcqk4E2zPYCA9x1BTw== X-Received: by 2002:a63:b53:: with SMTP id a19mr19302204pgl.216.1556584613110; Mon, 29 Apr 2019 17:36:53 -0700 (PDT) Received: from localhost ([12.206.222.5]) by smtp.gmail.com with ESMTPSA id j5sm47436174pfe.15.2019.04.29.17.36.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 29 Apr 2019 17:36:51 -0700 (PDT) Date: Mon, 29 Apr 2019 17:36:51 -0700 (PDT) X-Google-Original-Date: Mon, 29 Apr 2019 16:52:40 PDT (-0700) Subject: Re: [PATCH v3 1/3] RISC-V: Add RISC-V specific arch_match_cpu_phys_id In-Reply-To: <20190424062100.GB3902@infradead.org> CC: atish.patra@wdc.com, linux-kernel@vger.kernel.org, aou@eecs.berkeley.edu, dmitriy@oss-tech.org, anup@brainfault.org, johan@kernel.org, Christoph Hellwig , Paul Walmsley , schwab@suse.de, linux-riscv@lists.infradead.org, tglx@linutronix.de From: Palmer Dabbelt To: Christoph Hellwig Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 23 Apr 2019 23:21:00 PDT (-0700), Christoph Hellwig wrote: >> } >> + >> +bool arch_match_cpu_phys_id(int cpu, u64 phys_id) >> +{ >> + return phys_id == cpuid_to_hartid_map(cpu); >> +} >> /* Unsupported */ > > Please keep an empty line after function bodys. > > Otherwise looks good: > > Reviewed-by: Christoph Hellwig Oh, sorry, I missed this -- I just fixed up the patch and added your tag.