Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp4300517yba; Mon, 29 Apr 2019 17:41:52 -0700 (PDT) X-Google-Smtp-Source: APXvYqyRp+MJgMsq6W1toWLtmFGxYYs96QA7BTAp7Qaz3GUy08j25PXFSaEkIU8Xf0WmIvupGG/p X-Received: by 2002:a63:d10:: with SMTP id c16mr27063916pgl.156.1556584912320; Mon, 29 Apr 2019 17:41:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556584912; cv=none; d=google.com; s=arc-20160816; b=bIoyH2TyDHMFDQiDA/3VUQ/DHlDsTMtcJe0wDvbUbuXoXiFvTWYZ1sgKOjHdNAA7UN nJV+gGpR7lw2EQ53dXjGJ2LhZ3D1zOhzzT5ZTwM5xNXMM7TY1NlVGkY+8iQ1xjsVkfBH XubN1xg3vw8HUu82UCjd9A+loBtHFLpyjOyk20Ii6JWBU0hh7gwsbi553eXqb0mGy7Fa c/JfvSFHVNq4/1E+LPhtYqRSyBA2JjP94RcfA0blU6tTVz2h0MNjKBw+mkWHPP02V3Vc xJn0E1SQUgy1Cl8joMHSX1gs/CrRACwtQqSPKBBoxhmS+TWWRrkf4wGRuYIIV0MMEEIR trhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature; bh=LgDHqiBMkIEP2Gjv1b/BPNB6tTx6cNIX8WGn2OufiRQ=; b=MwOV4Nwwk56Q1zYr48AzKB/02el8yGODE5vXLKi9IARdp52O+7LW49+6Caz7yslrqs ARHTvaLh2lSgudvk/RvzbH9MSWb9b/eRwphatpazXKPi97UXlZ+aE+SLm6L82GXQv8hW SlX6UQN9kEbxQF5GAWTiz+4t0soR37oTizmDQC0UkvHhaG2Gdl8H63bM4IJUuO8CuQ8c AFd+TigFc1Kd7g0XBqefDbZ7ga/JujkixKBMkuAM0pkGwMkq5HtDnasGYkdryCJV+o3d mkTIIMpWI0HQaaDTmhnCKZRNF86OK5D0Im5zj4AAG8HhQSwosYMfJs2OvsDpVfbJ780C gfsg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@netronome-com.20150623.gappssmtp.com header.s=20150623 header.b="F2K/xby4"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e15si20935779pgm.377.2019.04.29.17.41.37; Mon, 29 Apr 2019 17:41:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@netronome-com.20150623.gappssmtp.com header.s=20150623 header.b="F2K/xby4"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729729AbfD3Ak2 (ORCPT + 99 others); Mon, 29 Apr 2019 20:40:28 -0400 Received: from mail-yw1-f67.google.com ([209.85.161.67]:44224 "EHLO mail-yw1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729238AbfD3Ak2 (ORCPT ); Mon, 29 Apr 2019 20:40:28 -0400 Received: by mail-yw1-f67.google.com with SMTP id j4so4663718ywk.11 for ; Mon, 29 Apr 2019 17:40:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=LgDHqiBMkIEP2Gjv1b/BPNB6tTx6cNIX8WGn2OufiRQ=; b=F2K/xby4cmu6d2bZoZHJLR5Z4UZj5CGWYwSUm3LxusNt5Jmmm9YeWtE5K9sqrAdZuk gwz6epfbgd98xGZRRXx2zBxmy2oDyAdASJQHHpO8rY3PjpCAFbhU+2RcJuuqUE4ZqfaW /leG3SS/9/y27TwwrXCfbtJGcjzg3UZBYRPMitXPLwSbOuAM8QaXoh6yQaQfT/IcPXeW vuVLqIIdHj1Ou0IAaxfLoslywy/E4eDi9gpDAv1OG1wWf0w2PeT6Qri71vyTbJcrqbUX KEuZ4nD3RjUSl0spMlo3D/3HRKtuTLpV0xrX3NhRVCe+vuVhpPIJcyxcKf7zQhI8Kwau YXQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=LgDHqiBMkIEP2Gjv1b/BPNB6tTx6cNIX8WGn2OufiRQ=; b=OaTx/QksC5ewpu+lf/z5EFPZcbZrbdRpPgvydz/+ixsUdbtWTSDJG2JhIDuwjUFX5s 2fsTHyEWIFCXNypNTSuSz4h43C2dLpPHXTGic6FYqLKIkod440d6PlSYciiH/Ha86EPB 3f6xfJ9HXj9C/NuTat832UZKp2x1b1imtozeTEulZiK6aJRVPODe7XGllDLuIBSy1LPi 8K/DNys5zvgYbxL/EwdIWZoOejfor0X9MTVO5bKWnMDpQRlhQalWaLfV9xrHVZSIEb9z KFMhbh4nRp1a7mR4/Kp0WLX+WXJrlhITgMz+MZjFKKcVVqQ4VnHByIQ7ojpSCLKo3mT7 N3+w== X-Gm-Message-State: APjAAAW607krTwkcaTYgxm/9h+uupAhp0ffqOIRAqzvhNXIx7JnXU6Cj uCyTY1mtVnXQ8COKLicS9ELfjNsLNRLQ0w== X-Received: by 2002:a81:3b13:: with SMTP id i19mr18065733ywa.100.1556584827229; Mon, 29 Apr 2019 17:40:27 -0700 (PDT) Received: from cakuba (adsl-173-228-226-134.prtc.net. [173.228.226.134]) by smtp.gmail.com with ESMTPSA id x189sm7834917ywb.41.2019.04.29.17.40.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 29 Apr 2019 17:40:27 -0700 (PDT) Date: Mon, 29 Apr 2019 20:40:23 -0400 From: Jakub Kicinski To: "Gustavo A. R. Silva" Cc: "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] netdevsim: fix fall-through annotation Message-ID: <20190429204023.259fe70a@cakuba> In-Reply-To: <20190429173807.GA18088@embeddedor> References: <20190429173807.GA18088@embeddedor> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 29 Apr 2019 12:38:07 -0500, Gustavo A. R. Silva wrote: > Replace "pass through" with a proper "fall through" annotation > in order to fix the following warning: >=20 > drivers/net/netdevsim/bus.c: In function =E2=80=98new_device_store=E2=80= =99: > drivers/net/netdevsim/bus.c:170:14: warning: this statement may fall thro= ugh [-Wimplicit-fallthrough=3D] > port_count =3D 1; > ~~~~~~~~~~~^~~ > drivers/net/netdevsim/bus.c:172:2: note: here > case 2: > ^~~~ >=20 > Warning level 3 was used: -Wimplicit-fallthrough=3D3 >=20 > This fix is part of the ongoing efforts to enable > -Wimplicit-fallthrough >=20 > Signed-off-by: Gustavo A. R. Silva Acked-by: Jakub Kicinski