Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] quota: set init_needed flag only when successfully
 getting dquot
To:     Jan Kara <jack@suse.cz>
Cc:     jack@suse.com, linux-kernel@vger.kernel.org
References: <20190428053921.5984-1-cgxu519@gmx.com>
 <20190429214956.GA6740@quack2.suse.cz>
From:   cgxu519 <cgxu519@gmx.com>
Message-ID: <5d005f7a-0e5b-57a5-44d4-83b12fdfa9e9@gmx.com>
Date:   Tue, 30 Apr 2019 10:27:15 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <20190429214956.GA6740@quack2.suse.cz>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 4/30/19 5:49 AM, Jan Kara wrote:
> On Sun 28-04-19 13:39:21, Chengguang Xu wrote:
>> Set init_needed flag only when successfully getting dquot,
>> so that we can skip unnecessary subsequent operation.
>>
>> Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
> Thanks for the patch but I don't think it's really useful. It will be very
> rare that we race with quotaoff of dqget() fails due to error. So the
> additional overhead of iterating over dquots doesn't really matter in that
> case.

Hi Jan,

Thanks for the comment, I got it.

Chengguang.