Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp4454904yba; Mon, 29 Apr 2019 21:26:10 -0700 (PDT) X-Google-Smtp-Source: APXvYqzH2C5AyyrLV5egBkts/SQufEGYNMYBV6oE+Ogx32/iPakPDGnEIU85Qn9vyVx0Ikz4UoTN X-Received: by 2002:a63:6fcd:: with SMTP id k196mr63112838pgc.238.1556598369922; Mon, 29 Apr 2019 21:26:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556598369; cv=none; d=google.com; s=arc-20160816; b=rm1nGJ9gcIimFDm0dL32DgPvTTm/E+VR8fYfZUNayaWct8t7p8M2AvPHjl9o2vQvYZ 6ikbOSm2JNKHSMM6jcM5jfKlAWlxU5S/qjG1U5VuHJ5PrL4TqjWiU5Bs7Jp84gfJKl3M 5mvFdIltwcBrEz7IS5AKI21FiZswZyrIhdXEx9FJYOJvqcLYO+naEIfzHLv5BuEKBpTB 0wFIc5IDviEVFNozY8unWtJ1OgaXU2N3p14ygDCAbuftR6CpyMLBs65H+qPZFZwRZY4n TQXExu1zB8kBpkP1MvLROdKdZTYKfmYeXi4mVf2fBO0LUUzJJZTwjwPjHGiw7/GJwN/s bX6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=DVA6yR4Sxy2an9BXJ5NALuY+dTspWhcDf3najxAmkPA=; b=INlKfr4NpNUdINeKbOlMsPLdVQOfetO5BRI2bS9I6xo6WW1kHlxbXQIZ3cFgtXvc8G jorHghnQXjHOzDFCLMZI4CdYMkk7pdj9LefMrZDkpMEyD0p47Oy+SKlr6Hfwm9BSHP/v B8WMujAAc/uxJl6nkyhUue5FNc1lQqiav8B5x4Yva0j43HdV21zTw49jaiQw5RD7baXh yFOQs4bKNf6G415of6gKu2uai0Gu+WxTY66TAh8dcZ4E20UbfBBV0LT4/xwgLbAIzx6+ QxKEhdVDfLvPK/EjWtUX0E5ZvsA0VyFSXfxONAIv7h+CynqTZXZf0c+yjpd8cjG+8yB8 DwOQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=nPeKKzZz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m5si34655658pll.132.2019.04.29.21.25.53; Mon, 29 Apr 2019 21:26:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=nPeKKzZz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725996AbfD3EYr (ORCPT + 99 others); Tue, 30 Apr 2019 00:24:47 -0400 Received: from mail-wr1-f49.google.com ([209.85.221.49]:33606 "EHLO mail-wr1-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725446AbfD3EYr (ORCPT ); Tue, 30 Apr 2019 00:24:47 -0400 Received: by mail-wr1-f49.google.com with SMTP id s18so19278576wrp.0 for ; Mon, 29 Apr 2019 21:24:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=DVA6yR4Sxy2an9BXJ5NALuY+dTspWhcDf3najxAmkPA=; b=nPeKKzZz5rmrdYvcZ5h29hW2YotW09hET0wvOByGsm56wjtEjm4bayirmeENjxYtBb UTaT113i/tWVOp3O6cAMgYhpBqLUPRWstymJK9/mnfktUb3yKrP/BAXxn5COPN41zb7O jqTK2ZNke3uY5NT9jo93w7NM9ih5y7GCLzT8/JpEqwP/66gfpziYpgZSHZ0rk5EXxKNy f9qDvug6ejJ97DGfpU7GL/ErBsO3mXFTzPrI+IKBK8R4wM4cUTqrWyCXPXne06lJrxeP arjKv7tD0dsBUzPS9KCNjY9Vwkw7hVw2hMTfBKFYjXd3fxAUcsLWB0IO72ZMJhLB68z4 oMfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=DVA6yR4Sxy2an9BXJ5NALuY+dTspWhcDf3najxAmkPA=; b=Eo37bzUIG3l1n0Ba3/GTiX3BsexKmQAYPi0QYpiRYOjtpFB/Drhmd+c/K2mP3g+QQd EHek01hNjBMMXpUBStTePLONTxsf22fMt8XYpBxamTGXTn0yJf81zhNs9yWNFnCsdslY EcBx3kou6mvhsguyXrYBZx7Az0RbQh8roG/kEF4iy+/K7reFmmt1aMFM0pVQIwVI/rex rdrqC/RsgJy+fQWd/Ail4ifaXde8IT7C4uZQC/63qTCVnrg3cl2AwxrPmT24yMi6cc+9 SS92vAD0I0feSGvMZVzi3y9xZqaTbDso5LhoP5jC/wKRILOSwPTmZz3MmRJCzXeW2XB6 D9ug== X-Gm-Message-State: APjAAAVaP7LwXO4eTY0/IleADF2p/7Da2bZCjve0UgKptfKVgzWcsufJ zAq/4TDivRmJG8u+3PMAMTw= X-Received: by 2002:adf:f6ca:: with SMTP id y10mr16153091wrp.241.1556598285871; Mon, 29 Apr 2019 21:24:45 -0700 (PDT) Received: from gmail.com (2E8B0CD5.catv.pool.telekom.hu. [46.139.12.213]) by smtp.gmail.com with ESMTPSA id u11sm188077wrg.35.2019.04.29.21.24.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 29 Apr 2019 21:24:45 -0700 (PDT) Date: Tue, 30 Apr 2019 06:24:43 +0200 From: Ingo Molnar To: "Tobin C. Harding" Cc: Ingo Molnar , Peter Zijlstra , Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND] sched/cpufreq: Fix kobject memleak Message-ID: <20190430042443.GB73609@gmail.com> References: <20190430001717.26533-1-tobin@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190430001717.26533-1-tobin@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Tobin C. Harding wrote: > Currently error return from kobject_init_and_add() is not followed by a > call to kobject_put(). This means there is a memory leak. > > Add call to kobject_put() in error path of kobject_init_and_add(). > > Signed-off-by: Tobin C. Harding > --- > > Resend with SOB tag. Please ignore my previous mail :-) Thanks, Ingo