Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH V2] rds: ib: force endiannes annotation
To:     Nicholas Mc Guire <hofrat@osadl.org>
Cc:     "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org,
        linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com,
        linux-kernel@vger.kernel.org
References: <1556593977-15828-1-git-send-email-hofrat@osadl.org>
From:   "santosh.shilimkar@oracle.com" <santosh.shilimkar@oracle.com>
Organization: Oracle Corporation
Message-ID: <5ba055e9-5221-bff2-fdd2-d4b837c95ce1@oracle.com>
Date:   Mon, 29 Apr 2019 21:25:15 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0)
 Gecko/20100101 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <1556593977-15828-1-git-send-email-hofrat@osadl.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 4/29/19 8:12 PM, Nicholas Mc Guire wrote:
> While the endiannes is being handled correctly as indicated by the comment
> above the offending line - sparse was unhappy with the missing annotation
> as be64_to_cpu() expects a __be64 argument. To mitigate this annotation
> all involved variables are changed to a consistent __le64 and the
>   conversion to uint64_t delayed to the call to rds_cong_map_updated().
> 
> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
> ---
> 
> Problem located by an experimental coccinelle script to locate
> patters that make sparse unhappy (false positives):
> net/rds/ib_recv.c:827:23: warning: cast to restricted __le64
> 
> V2: Edward Cree <ecree@solarflare.com> rejected the need for using __force
>      here - instead solve the sparse issue by updating all of the involved
>      variables - which results in an identical binary as well without using
>      the __force "solution" to the sparse warning. Thanks !
> 
> Patch was compile-tested with: x86_64_defconfig + INFINIBAND=m, RDS_RDMA=m
> 
> Patch was verified not to change the binary by diffing the
> generated object code before and after applying the patch.
> 
Thanks. I was worried about this macro magic o.w

Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>