Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp4490543yba; Mon, 29 Apr 2019 22:18:11 -0700 (PDT) X-Google-Smtp-Source: APXvYqywiSFAWWH9ZsMVhtooJkv7FyFNBj0r5F9qANUA5wvuU/eRX5RKemVjxknOW3q30c30f7ro X-Received: by 2002:aa7:91c8:: with SMTP id z8mr69376438pfa.110.1556601491903; Mon, 29 Apr 2019 22:18:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556601491; cv=none; d=google.com; s=arc-20160816; b=l+lWnvUv62SfMdaDySXbd4GHz+qyY5xx3rzkqH8ev7IR0gQeD/WjoVAEc2LEhcDfbu LouFejPRCj0gcdQpKaC8nTorT9u3BGxv7Igx/Pcw2oAFAtltJU19lWDrPm0+SVybWP0r 7sgyCy3DhkzFc63nNneHM6x5KAbfXNx5/XDEKnms3mgnBW9XWK9LKGpNzYtTLzZrKqnb Is4rqDwy1HQ8WYT3iD2wChmeHxNhAIDWcJK+ZKNd7DL2GrE3sXtO448g2NAuq1ZYQu2r gh0OtKg9fFZxE86XZm6nmEV1mi3UtLCDPeKlBVElyrZZmWhziMLFZ0oS15mkxSaugMXy xMTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:dkim-signature; bh=DUYD7xRlE61Rnxv7xoYW7Ssfsx5LnGk2D3PkL/WJ8Ik=; b=NswpEbc5yqhhgwrA3Mcfz1Le1Mgr4YOi7+q8upxZKYK7UnHIN0LPqMJLSmeWQcnAdN USJv+7fQSr3L0Z7M7wcdC98S8/GwUYTg4FrC615x3WSoFEoQW2wdt6Zj+lxq8KVZF/MX 5OFSwgeowrA2sIJY7iLQjDiKwFglem92pyBVyRpsp4WcrPWLUdj70FBtgZYHeFZudB87 h7hWHuWyw4X7r8wbT7F9HhC7fg3rYXR1RdedE6ySCC6ra+pxR4S7b8Ajr9FlQejEjxkO 8JZQDCsvu/vgtfvmcvlCWrPy7fKx0IOy98TX7l/LMbhWXOHA9TCOlbVhtuuNMIrZVejD dbRQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@tobin.cc header.s=fm3 header.b="hDMWL/Jz"; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=Po303dIK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o33si5220031plb.230.2019.04.29.22.17.56; Mon, 29 Apr 2019 22:18:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@tobin.cc header.s=fm3 header.b="hDMWL/Jz"; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=Po303dIK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726213AbfD3FQa (ORCPT + 99 others); Tue, 30 Apr 2019 01:16:30 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:42487 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725446AbfD3FQa (ORCPT ); Tue, 30 Apr 2019 01:16:30 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 7862B27CE8; Tue, 30 Apr 2019 01:16:29 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 30 Apr 2019 01:16:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tobin.cc; h=date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=DUYD7xRlE61Rnxv7xoYW7Ssfsx5 LnGk2D3PkL/WJ8Ik=; b=hDMWL/JzlkFybHuKb0MoXkqVAJkasMpnqEirHt4VObt kwYj3tWdgRv9P+roD9UIUfrr3j0xSICayLEk8e73AuaiVaWFVA2E5kCqnwE3INpE zYxQpz3t58Y/Kkir7XVcQ4+XzhSiaZKiUtL0ZeBmwIQV0Hvkh0AgLm/1rPSf9YEq K3bkgHyJVWT6+FXAlluCe4cVJfVAd0b98xsHk+FxO/enJNHO4ud88akbM0KMliJ2 kE7/KpQIjUz5KfqpRk5az+OJJcW1q3bsv2FZi3GIzYZmZNLF2TsSH+a0BmNSC9cd IVQOO/XVnwAXiPanEKkWWPdwmkwot5xejveBH0CYp6A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=DUYD7x RlE61Rnxv7xoYW7Ssfsx5LnGk2D3PkL/WJ8Ik=; b=Po303dIKhLf++y10KwKR2b 19s96KvZ5tCil9B5fdw/n/y8LO2K1zQyJ4RMkz7wLAOSiEW+ZmNzW+IJZSd7Gaej oy/XBRfzJtTer3IPaREI7Sinu7Fwx3qyX0gEIQI/SFYWc/cdQJvP+gQJyfK8cebx jVA5dne+aZ9v+45RYs4E5LyVkJtAMW4dB4dt/8wqGbS5TT0PPe8RXhK3Ywv3zFsK MgcdGZJjeUUSYqSsQ7sWui3xvYhKWw4HnLP2L+F5/U+Prj2kZd2NRFu3QB5G05yQ zFIXZliIR7jwRpRyf2/Ys0RFA9QWrJXgpybcPYpPxqkhGyHVCZgHbJOjUAZm7fNA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrieefgdelhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdduhedmnecujfgurhepfffhvffukfhfgggtuggjofgfsehttdertdfo redvnecuhfhrohhmpedfvfhosghinhcuvedrucfjrghrughinhhgfdcuoehmvgesthhosg hinhdrtggtqeenucfkphepuddvuddrgeegrddvfedtrddukeeknecurfgrrhgrmhepmhgr ihhlfhhrohhmpehmvgesthhosghinhdrtggtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from localhost (ppp121-44-230-188.bras2.syd2.internode.on.net [121.44.230.188]) by mail.messagingengine.com (Postfix) with ESMTPA id 539E7103C9; Tue, 30 Apr 2019 01:16:28 -0400 (EDT) Date: Tue, 30 Apr 2019 15:15:45 +1000 From: "Tobin C. Harding" To: Ingo Molnar Cc: "Tobin C. Harding" , Ingo Molnar , Peter Zijlstra , Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND] sched/cpufreq: Fix kobject memleak Message-ID: <20190430051545.GB30100@eros.localdomain> References: <20190430001717.26533-1-tobin@kernel.org> <20190430042443.GB73609@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190430042443.GB73609@gmail.com> X-Mailer: Mutt 1.11.4 (2019-03-13) User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 30, 2019 at 06:24:43AM +0200, Ingo Molnar wrote: > > * Tobin C. Harding wrote: > > > Currently error return from kobject_init_and_add() is not followed by a > > call to kobject_put(). This means there is a memory leak. > > > > Add call to kobject_put() in error path of kobject_init_and_add(). > > > > Signed-off-by: Tobin C. Harding > > --- > > > > Resend with SOB tag. > > Please ignore my previous mail :-) Cheers Ingo, caught myself not checkpatching :( thanks, Tobin.