Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp4578766yba; Tue, 30 Apr 2019 00:20:30 -0700 (PDT) X-Google-Smtp-Source: APXvYqw7J0xgJxw3kTzyT/Eij4u44mvgPk2W28Nbd/MnTsCU7M/p9b4W92IHfMZdPEcDa5Mtu3DK X-Received: by 2002:a17:902:a515:: with SMTP id s21mr16614350plq.131.1556608830308; Tue, 30 Apr 2019 00:20:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556608830; cv=none; d=google.com; s=arc-20160816; b=qi4ZGpmLFzSKS5Mxqj20vz6aMFvZEDwfGLKIaiQ10N2CVmAT4a/pFizmDB8gn+pjAq +N19pZehMNe1EaS0Xodjol3ov55yv24QIPpRpYZOFVirn02OdKOHqFoZJQ+kwAPax/1R qd77b5HVifcOdp1WZQ9kks2zhtLxkG4OYdpKAUs/5zK7oTQUOe5BZ299JmPh5HK8hIq9 CuU6PXl22zlcjKg91/NXrWh78Cjkki8nEvmDQZrKHT/mG39V7Q41DapndzhRfVf0rY3L +MbV9G/wORwAN7iPsdy4hgVGOM+lxqJZYIvf0BN+qGJW2mDyRjE8lvrVlR0NLY1OcbYj rcCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Rpzmwdl5cQX3zB4mZmJH9bmpm9cPkiPX1F70gCxBmFY=; b=BxOrethswMqEYRxDNww+r9UhfIlIc/KZRwQzgBAvfy3NY0zrifdalAzZ6XASjjhyL8 PW7goN6j/VSy8HJb0l/WDrLEaAldZp1NVcxpVwf3F84trMgMsJ1bJVRpRXpgORHc8vng M02H+Ox4Bi+7o+NxpQN29V14lFQzY42yn8Bohu72HhhG7JbC0A/mpsO7voVIL0uFuqjo 4DRdHed39LUwgiv7JlKbf55foBf86E6T5MgF6PGLcx6yUfSZlYnqrIJ+tMvHZ7p7QAK+ qzZ0LCe8fiO2p9H9RmjPF+GRmZop7rMpYOjgod88kCXq4A7BZXgBNl/b/nQIFZ1g3mii 3nTw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@geanix.com header.s=first header.b=jUramFxI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=geanix.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f1si33328238pgv.195.2019.04.30.00.20.14; Tue, 30 Apr 2019 00:20:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@geanix.com header.s=first header.b=jUramFxI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=geanix.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726755AbfD3HS5 (ORCPT + 99 others); Tue, 30 Apr 2019 03:18:57 -0400 Received: from first.geanix.com ([116.203.34.67]:43798 "EHLO first.geanix.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726706AbfD3HSu (ORCPT ); Tue, 30 Apr 2019 03:18:50 -0400 Received: from localhost (unknown [193.163.1.7]) by first.geanix.com (Postfix) with ESMTPSA id F240B308EA3; Tue, 30 Apr 2019 07:18:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=geanix.com; s=first; t=1556608723; bh=d5jSy2G73aQlTbm0gKX8UO9SuypNh5XD4AWqgpyyw8o=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=jUramFxIeEYeFnLsreuoaW7Gk7DBAG10Otw/uPkYe2YOyWmGnXUvm+pDNooCBJg2U Hnf0GjP7UzeLsPaHFwg/93ZvrpzQdb82Bqh9ExCwpX71jP5vOqIgjlKC8WSWLHT0zr FKDIoeozLbhsrKW59/JPE/XcsfwQE89XX1IJbtEeuby/IQ6Kfc3k18lzUSXhQgYkgn zHi1oXQVFX/3LWkVcCToCDRbhi3CthF3zt4WamYw/QRNbuBAHFftmrrU5zqB0oR7eN tWBPzb2W3LYMqJVvbgbsm0C5whRJV2kS1kAS9LIf/J4JqyHh8wjNDp0LQf0Rjb5rFU Ml+pkAwmH9BOQ== From: Esben Haabendal To: netdev@vger.kernel.org Cc: "David S. Miller" , Michal Simek , Luis Chamberlain , YueHaibing , Yang Wei , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 12/12] net: ll_temac: Enable DMA when ready, not before Date: Tue, 30 Apr 2019 09:17:59 +0200 Message-Id: <20190430071759.2481-13-esben@geanix.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190430071759.2481-1-esben@geanix.com> References: <20190429083422.4356-1-esben@geanix.com> <20190430071759.2481-1-esben@geanix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=disabled version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on b7bf6291adac Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As soon as TAILDESCR_PTR is written, DMA transfers might start. Let's ensure we are ready to receive DMA IRQ's before doing that. Signed-off-by: Esben Haabendal --- drivers/net/ethernet/xilinx/ll_temac_main.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c index bccef30..1003ee1 100644 --- a/drivers/net/ethernet/xilinx/ll_temac_main.c +++ b/drivers/net/ethernet/xilinx/ll_temac_main.c @@ -314,17 +314,21 @@ static int temac_dma_bd_init(struct net_device *ndev) CHNL_CTRL_IRQ_EN | CHNL_CTRL_IRQ_ERR_EN | CHNL_CTRL_IRQ_DLY_EN | CHNL_CTRL_IRQ_COAL_EN); - lp->dma_out(lp, RX_CURDESC_PTR, lp->rx_bd_p); - lp->dma_out(lp, RX_TAILDESC_PTR, - lp->rx_bd_p + (sizeof(*lp->rx_bd_v) * (RX_BD_NUM - 1))); - lp->dma_out(lp, TX_CURDESC_PTR, lp->tx_bd_p); - /* Init descriptor indexes */ lp->tx_bd_ci = 0; lp->tx_bd_next = 0; lp->tx_bd_tail = 0; lp->rx_bd_ci = 0; + /* Enable RX DMA transfers */ + wmb(); + lp->dma_out(lp, RX_CURDESC_PTR, lp->rx_bd_p); + lp->dma_out(lp, RX_TAILDESC_PTR, + lp->rx_bd_p + (sizeof(*lp->rx_bd_v) * (RX_BD_NUM - 1))); + + /* Prepare for TX DMA transfer */ + lp->dma_out(lp, TX_CURDESC_PTR, lp->tx_bd_p); + return 0; out: @@ -789,6 +793,7 @@ temac_start_xmit(struct sk_buff *skb, struct net_device *ndev) skb_tx_timestamp(skb); /* Kick off the transfer */ + wmb(); lp->dma_out(lp, TX_TAILDESC_PTR, tail_p); /* DMA start */ return NETDEV_TX_OK; -- 2.4.11