Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 30 Apr 2019 11:32:06 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Chengguang Xu <cgxu519@gmx.com>
Cc:     gregkh@linuxfoundation.org, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH] chardev: set variable ret to -EBUSY before
 checking minor range overlap
Message-ID: <20190430083206.GA2239@kadam>
References: <20190426073837.23086-1-cgxu519@gmx.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190426073837.23086-1-cgxu519@gmx.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Please don't say RESEND, say [PATCH v2].  RESEND is for when we ignored
your patch.  (Maybe we made a mistake or maybe the mailing list tagged
it as spam and deleted it or something).  Use [PATCH v2] instead.

On Fri, Apr 26, 2019 at 03:38:37PM +0800, Chengguang Xu wrote:
> When allocating dynamic major, the minor range overlap check
> in __register_chrdev_region() will not fail, so actually
> there is no real case to passing non negative error code to
> caller. However, set variable ret to -EBUSY before chekcking
> minor range overlap will avoid false-positive warning from
> code analyzing tool(like Smatch) and also make the code more
> easy to understand.
> 
> Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
> ---

Then here under the --- cut off line put:

v2: rebase against the latest linux-next

That way we will remember why the patch was sent twice and what changed.

>  fs/char_dev.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 

regards,
dan carpenter