Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp4641938yba;
        Tue, 30 Apr 2019 01:45:48 -0700 (PDT)
X-Google-Smtp-Source: APXvYqyhCzWopQZtVIoEk1m8bor3g2lQVKIPWzUgjKHwfyIrHSqwGAdzJ9k9p6ygTzDhBvwYeyeM
X-Received: by 2002:a63:af45:: with SMTP id s5mr64079866pgo.420.1556613948370;
        Tue, 30 Apr 2019 01:45:48 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1556613948; cv=none;
        d=google.com; s=arc-20160816;
        b=VMyGWmQvtLWfM6StZ5sKe6ATQo85tsGFh6w2MvwBwW7dSFb5QL0Hl1KosNTdbgkn3k
         6qamLV/RDUNQnfRvQWzdLXYs/4botxnPVcmG1IHbiK3mZtdsikCxXq9roT4LlFGG3gFS
         Z637JZfp571IIQxPvd9IhccxpFw55Zu2dXXtkATFpp++leyUGZ0FIehP3VnaH0CuTXr2
         pj3WnWEyh48stR0+ZUzkuy5qOTUJOE8weNHMcCMVU6VFmExuN/WDbIIgkuOsCRvjVQk5
         ut/ei7yzPm167KcUvbCV6r6wMCTHajEo4HqOLx7Vk4y0CDRpYxE3wzTOZGVTVEaWudAL
         wuzg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:user-agent:in-reply-to
         :content-disposition:mime-version:references:message-id:subject:cc
         :to:from:date:dkim-signature;
        bh=c4OQJfGt0QrqDbEh6BzxzbUSSV8KK7NxS7sgE7vrs8s=;
        b=XCvHIr0sqPQPFDRaHnyMlhQBZ8+V1tVIKEBGI7wt6NXLhg4Je3Fwyb3/2/DRCRjFzv
         KLOwY7wZ7H8VG88gzVxGjFcpYeo4xCcfWBcrUJdfPg93EDOGjY4lQvAvalqHvfPVfdHO
         NFDKn/4zRFR3/Turk+0N7zmBWCViW018AtFVTriP9DSRNGGtCTKKCVEeDuop7VVOZ/MG
         fA7j8IXDoyYqjRPlTVrahd1P18MOfCmAF/lEDNW8cdW4cX/BjmWopz5S88nqEh9IgDsl
         BbyeiV8Gg+IGRdVcQzGCKJ9S9kQ3RcESKkbiq4A117z8OrZQD2aeUil/Ydl94wH4NwRK
         BuIg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=KtQ3efFr;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id 61si37121206plf.290.2019.04.30.01.45.32;
        Tue, 30 Apr 2019 01:45:48 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=KtQ3efFr;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726779AbfD3Im6 (ORCPT <rfc822;1990.zhangzhen@gmail.com>
        + 99 others); Tue, 30 Apr 2019 04:42:58 -0400
Received: from mail.kernel.org ([198.145.29.99]:57360 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726012AbfD3Im5 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 30 Apr 2019 04:42:57 -0400
Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id A9BC92080C;
        Tue, 30 Apr 2019 08:42:56 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1556613777;
        bh=7o7DZwJEOripkUNr9As7Pg/o4reVXy70s+lqUnjJVJY=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=KtQ3efFrzbYXBRfbiJGPj+G83y9rGU5I9w+BoXWL+C/1NJjp7OAj3dpgXe4eAuMo5
         ZKYr3jn5ysbaPvnLontEDZtEJiZGNyE9ZVuovs1rgVaqzqjJnfA2ZmzjHvMzrc3Iy8
         ytIgyUJRPe1EMlwtkGeK0i4Ugx8rmicU2JDtJqG0=
Date:   Tue, 30 Apr 2019 10:42:54 +0200
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     "Tobin C. Harding" <tobin@kernel.org>
Cc:     Josh Poimboeuf <jpoimboe@redhat.com>,
        Jiri Kosina <jikos@kernel.org>,
        Miroslav Benes <mbenes@suse.cz>,
        Petr Mladek <pmladek@suse.com>,
        Joe Lawrence <joe.lawrence@redhat.com>,
        live-patching@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] livepatch: Fix kobject memleak
Message-ID: <20190430084254.GB11737@kroah.com>
References: <20190430001534.26246-1-tobin@kernel.org>
 <20190430001534.26246-2-tobin@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190430001534.26246-2-tobin@kernel.org>
User-Agent: Mutt/1.11.4 (2019-03-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Apr 30, 2019 at 10:15:33AM +1000, Tobin C. Harding wrote:
> Currently error return from kobject_init_and_add() is not followed by a
> call to kobject_put().  This means there is a memory leak.
> 
> Add call to kobject_put() in error path of kobject_init_and_add().
> 
> Signed-off-by: Tobin C. Harding <tobin@kernel.org>

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>