Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp4642143yba; Tue, 30 Apr 2019 01:46:06 -0700 (PDT) X-Google-Smtp-Source: APXvYqwbS5ucYM70NtT+gAumYK60i8lFPEMeFm0r1p4UG+9kLFLfK7ONrCYDr9nbPneN+K4U41Xi X-Received: by 2002:a65:4802:: with SMTP id h2mr59917558pgs.98.1556613965909; Tue, 30 Apr 2019 01:46:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556613965; cv=none; d=google.com; s=arc-20160816; b=hOHGVXnQvUbqFudvxDoaGQfP+R0BRGPnxFrEPNdnf+/StXuyI/kT7koufKJp/VoJGB wGgpdMe/m2zCoTQmvqvyLFBihMbyIrPHoK+UOhnUASoC79hQHmX/cCZLBb7VKXPPSjtF 0QzC/K5pex7XApE/ivbJNoQNa0TKVU7o1dtatYtEbCBeKEzS4NllQ3wemowzJ+UUPyWI C3vfjRZtSP9L3EmYCN7MDSUCh4uFEVUQLeyWyUfWKSOJm8VgppQihA23v/S+P8zWBVsu n+GwU7jVrn7IzUuMbJNFdLC+I5iLk6FbvvHD5kaThojpNy1aQ63d1nQ39Sv3IFGJSohV I9rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=5dYiRKVo7NXk7/5L06VNfd2EUU4Gw2fBVsxLrYzKXZc=; b=RyEYxq4by0uDF+mIJH9Kbj4wZwxpNypWk70mSlL1sqQttAYYlxv181ONwutIYfJtRs NeKE0cIpko0u9vrl2WpD0+VMYowzpxuyR70cvXQb8xOO1czRvbmhPTSt+phLka0JI7M/ qCLegvbZdYVEqxhxP8omsCeYI2/FqZqFjjZMZ3Zk4/MZ2/GAY+v+dfLWJwQOuAjDPBdO VNJmD9bjXcsjsk7iLn1zwWUWRJfSxho4UkEFoPtHPhCcfU/cB1pWXndc6thnzhSCNIck LbS9yaoCKSuJgecKPmmmQ/UXqDXErZCcIUGvy/kbbBMTFF2WpPz5lQsYuoLPI1X1179I wSHQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=yq4hYiya; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b3si32869982pgq.325.2019.04.30.01.45.50; Tue, 30 Apr 2019 01:46:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=yq4hYiya; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726801AbfD3In0 (ORCPT + 99 others); Tue, 30 Apr 2019 04:43:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:57474 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725769AbfD3In0 (ORCPT ); Tue, 30 Apr 2019 04:43:26 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9AD3821734; Tue, 30 Apr 2019 08:43:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556613805; bh=k4lffYt4nfcLJvq+4lOX31GNB0aCw11/OWOTdPr5ZkI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=yq4hYiya+lzKJr7EScWcV6JPy5s7m6J4wpYzCxASQqElg/wtHjkPK7ocOnO+EMSm4 yBZRQlfIIpPZT7HglgQ5fxWKX+ojWb1mkBlr8e8y3/NqcABNy6Kig51QXGhdApjamW whswbyMaON/tSMuBMyHdRrTYUuIbbSlm7S3D5ggA= Date: Tue, 30 Apr 2019 10:43:23 +0200 From: Greg Kroah-Hartman To: "Tobin C. Harding" Cc: Josh Poimboeuf , Jiri Kosina , Miroslav Benes , Petr Mladek , Joe Lawrence , live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] livepatch: Use correct kobject cleanup function Message-ID: <20190430084323.GC11737@kroah.com> References: <20190430001534.26246-1-tobin@kernel.org> <20190430001534.26246-3-tobin@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190430001534.26246-3-tobin@kernel.org> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 30, 2019 at 10:15:34AM +1000, Tobin C. Harding wrote: > The correct cleanup function after a call to kobject_init_and_add() has > succeeded is kobject_del() _not_ kobject_put(). kobject_del() calls > kobject_put(). > > Use correct cleanup function when removing a kobject. > > Signed-off-by: Tobin C. Harding Reviewed-by: Greg Kroah-Hartman