Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp4682096yba; Tue, 30 Apr 2019 02:35:35 -0700 (PDT) X-Google-Smtp-Source: APXvYqwrcrpmwwEpBDR3TZBEXJLlFvx8O0aj0R7NDsgwppMUQif4HtytJUzab2GP1ujNdGbPjyB1 X-Received: by 2002:a65:5045:: with SMTP id k5mr37499261pgo.235.1556616935561; Tue, 30 Apr 2019 02:35:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556616935; cv=none; d=google.com; s=arc-20160816; b=NRP6GCpAf0FPD0ABSpo7UMtn9Ykj8Noqr68toutH9xi2gvhSdXjlj1oQm8xaHN3rzO u8p6tl9762h8fKukXPWJyVt7N8ww86//71p21UvTzQXRQtiA2L9EVAgUKmHqE1LlDMJK LywHRJmnTiNeX78xaqZ+nk66ZBqWS1edAKmasVPXRjPEf1NbqWjToydl37tM74fdr/cy /mTuuBvnjHD8VVG4GFU6YAL7svGIHZCaDGeY/mSCgYCMyQ4yAT8SXkSoJPyH/kk9hPkP vf+4JTaITS9Nma5Q8/7Hlhkvxa9JWvi8nYxJYvtfO0LZ5Z8rRGuOIkzA7e9EpOA02ICr FMog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Ljxzd7ohjGfa/y1AJl6pGQde15gtyslFFyhUFGUUNAU=; b=dN88HJDVKlFpVMuxrAzQJniJ3C9Y5SFxvN4tNds94O1DLJqUXjC23q88uAnNx1KfzB aKQO+sluEXA1NXjn/JMvEGRaytRnWcm2pFwRYSLI0FyBA2KJcN/aT/rjqpPBBfUWU8gW xHCQVcFP1R5yB3uGESj4YnrY+Sq1KAG+ZV/h964faQ5kudyVN8c8dqKD8b4EBxdCdgTI bbhRvSGjvGXGsPhC7CdFa8o5fsLS8AKiXlrta1dzDxpC+sUWykpiORZWHT0Sxu3fblwv /PXqIGtVCt5AjmrEpuWd5dO4Knmp1q83ODoq91RdGAWlZCGDp0TLXxPchACjgv6rYRkp N+bQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b="lotr40/n"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b144si23467375pfb.184.2019.04.30.02.35.20; Tue, 30 Apr 2019 02:35:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b="lotr40/n"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727021AbfD3Jdq (ORCPT + 99 others); Tue, 30 Apr 2019 05:33:46 -0400 Received: from mail.skyhub.de ([5.9.137.197]:44208 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726263AbfD3Jdq (ORCPT ); Tue, 30 Apr 2019 05:33:46 -0400 Received: from zn.tnic (p200300EC2F073600329C23FFFEA6A903.dip0.t-ipconnect.de [IPv6:2003:ec:2f07:3600:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 393941EC0AD8; Tue, 30 Apr 2019 11:33:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1556616824; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=Ljxzd7ohjGfa/y1AJl6pGQde15gtyslFFyhUFGUUNAU=; b=lotr40/nuVuGL3vT4h5G5VutB3s/wvjt+rcxHxqIws9p6QtZFSfqlfc2dZuJpC7m5U4E1/ EGKwZUYIHuHBHu5Fxt7TTO3z0aZx/cnJdDp7mGCIRz0LYOTzconMBId6hWj/0xCxBhjksk Z8s4M+PeugmXqVWcwWeZW5A353F/qcA= Date: Tue, 30 Apr 2019 11:33:38 +0200 From: Borislav Petkov To: Len Brown Cc: Peter Zijlstra , X86 ML , linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/14] v2 multi-die/package topology support Message-ID: <20190430093338.GA3518@zn.tnic> References: <20190226062012.23746-1-lenb@kernel.org> <20190226190512.GR2861@worktop.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 30, 2019 at 02:50:58AM -0400, Len Brown wrote: > If one were to make a change here, I'd consider adding the (physical) die_id, > though it is already in sysfs topology as an attribute. From: Documentation/x86/topology.txt "The kernel does not care about the concept of physical sockets because a socket has no relevance to software. It's an electromechanical component. In the past a socket always contained a single package (see below), but with the advent of Multi Chip Modules (MCM) a socket can hold more than one package. So there might be still references to sockets in the code, but they are of historical nature and should be cleaned up." So that die thing has only small relevance to some software, as you say: "These topology changes primarily impact parts of the kernel and some applciations that care about package MSR scope." So if there's no real need to add it there, then it probably shouldn't be added. The topology is already too complex - so much so, that tools are even generating PDFs from it :) -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.